Added a TODO about RefusedFilter in hierarchical allocator. Review: https://reviews.apache.org/r/35838
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e74853e3 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e74853e3 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e74853e3 Branch: refs/heads/master Commit: e74853e35640e606868a0101add502bdd7fe8484 Parents: cca2b80 Author: Jie Yu <[email protected]> Authored: Wed Jun 24 14:51:26 2015 -0700 Committer: Jie Yu <[email protected]> Committed: Thu Jun 25 10:25:44 2015 -0700 ---------------------------------------------------------------------- src/master/allocator/mesos/hierarchical.hpp | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/e74853e3/src/master/allocator/mesos/hierarchical.hpp ---------------------------------------------------------------------- diff --git a/src/master/allocator/mesos/hierarchical.hpp b/src/master/allocator/mesos/hierarchical.hpp index c6acdae..3264d14 100644 --- a/src/master/allocator/mesos/hierarchical.hpp +++ b/src/master/allocator/mesos/hierarchical.hpp @@ -297,6 +297,11 @@ public: virtual bool filter(const SlaveID& _slaveId, const Resources& _resources) { + // TODO(jieyu): Consider separating the superset check for regular + // and revocable resources. For example, frameworks might want + // more revocable resources only or non-revocable resources only, + // but currently the filter only expires if there is more of both + // revocable and non-revocable resources. return slaveId == _slaveId && resources.contains(_resources) && // Refused resources are superset. timeout.remaining() > Seconds(0);
