Integer Precision for JSON <-> Protobuf conversions. Modify one libprocess test to match changes to JSON::Number.
Review: https://reviews.apache.org/r/38076 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1116ad50 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1116ad50 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1116ad50 Branch: refs/heads/master Commit: 1116ad50f98ce84569d954debcf630e699cbf419 Parents: f7080d0 Author: Joseph Wu <[email protected]> Authored: Fri Sep 18 12:11:35 2015 -0400 Committer: Joris Van Remoortere <[email protected]> Committed: Fri Sep 18 12:37:18 2015 -0400 ---------------------------------------------------------------------- 3rdparty/libprocess/src/tests/metrics_tests.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/1116ad50/3rdparty/libprocess/src/tests/metrics_tests.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/tests/metrics_tests.cpp b/3rdparty/libprocess/src/tests/metrics_tests.cpp index 29ed033..8f15ee7 100644 --- a/3rdparty/libprocess/src/tests/metrics_tests.cpp +++ b/3rdparty/libprocess/src/tests/metrics_tests.cpp @@ -193,10 +193,10 @@ TEST(MetricsTest, Snapshot) map<string, JSON::Value> values = responseJSON.get().values; EXPECT_EQ(1u, values.count("test/counter")); - EXPECT_FLOAT_EQ(0.0, values["test/counter"].as<JSON::Number>().value); + EXPECT_FLOAT_EQ(0.0, values["test/counter"].as<JSON::Number>().as<double>()); EXPECT_EQ(1u, values.count("test/gauge")); - EXPECT_FLOAT_EQ(42.0, values["test/gauge"].as<JSON::Number>().value); + EXPECT_FLOAT_EQ(42.0, values["test/gauge"].as<JSON::Number>().as<double>()); EXPECT_EQ(0u, values.count("test/gauge_fail")); @@ -290,10 +290,10 @@ TEST(MetricsTest, SnapshotTimeout) map<string, JSON::Value> values = responseJSON.get().values; EXPECT_EQ(1u, values.count("test/counter")); - EXPECT_FLOAT_EQ(0.0, values["test/counter"].as<JSON::Number>().value); + EXPECT_FLOAT_EQ(0.0, values["test/counter"].as<JSON::Number>().as<double>()); EXPECT_EQ(1u, values.count("test/gauge")); - EXPECT_FLOAT_EQ(42.0, values["test/gauge"].as<JSON::Number>().value); + EXPECT_FLOAT_EQ(42.0, values["test/gauge"].as<JSON::Number>().as<double>()); EXPECT_EQ(0u, values.count("test/gauge_fail")); EXPECT_EQ(0u, values.count("test/gauge_timeout")); @@ -381,7 +381,9 @@ TEST(MetricsTest, SnapshotStatistics) const JSON::Value& value, responseJSON.get().values) { if (value.is<JSON::Number>()) { - responseValues[key] = value.as<JSON::Number>().value; + // "test/counter/count" is an integer, everything else is a double. + JSON::Number number = value.as<JSON::Number>(); + responseValues[key] = number.as<double>(); } }
