Repository: mesos Updated Branches: refs/heads/master 883064698 -> 2eca0546e
Added a NOTE in docker store about caching. Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2eca0546 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2eca0546 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2eca0546 Branch: refs/heads/master Commit: 2eca0546e84e47283b4ea411c4d5bbc4e03bbd44 Parents: ca0df27 Author: Jie Yu <[email protected]> Authored: Fri Feb 19 10:44:49 2016 -0800 Committer: Jie Yu <[email protected]> Committed: Fri Feb 19 10:45:09 2016 -0800 ---------------------------------------------------------------------- src/slave/containerizer/mesos/provisioner/docker/store.cpp | 6 ++++++ 1 file changed, 6 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/2eca0546/src/slave/containerizer/mesos/provisioner/docker/store.cpp ---------------------------------------------------------------------- diff --git a/src/slave/containerizer/mesos/provisioner/docker/store.cpp b/src/slave/containerizer/mesos/provisioner/docker/store.cpp index 934a306..e7dd54a 100644 --- a/src/slave/containerizer/mesos/provisioner/docker/store.cpp +++ b/src/slave/containerizer/mesos/provisioner/docker/store.cpp @@ -185,6 +185,12 @@ Future<Image> StoreProcess::_get( const spec::ImageReference& reference, const Option<Image>& image) { + // NOTE: Here, we assume that image layers are not removed without + // first removing the metadata in the metadata manager first. + // Otherwise, the image we return here might miss some layers. At + // the time we introduce cache eviction, we also want to avoid the + // situation where a layer was returned to the provisioner but is + // later evicted. if (image.isSome()) { return image.get(); }
