Repository: mesos Updated Branches: refs/heads/master 7d27e3ace -> e7bf541c9
Explained why fields in the acts.Entity must be required. Review: https://reviews.apache.org/r/48936/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/30d703fe Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/30d703fe Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/30d703fe Branch: refs/heads/master Commit: 30d703fe81eacf64e9d84503074579cf5667bea1 Parents: 7d27e3a Author: Alexander Rukletsov <ruklet...@gmail.com> Authored: Mon Jun 20 15:35:40 2016 +0200 Committer: Alexander Rukletsov <al...@apache.org> Committed: Mon Jun 20 15:35:40 2016 +0200 ---------------------------------------------------------------------- include/mesos/authorizer/acls.proto | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/30d703fe/include/mesos/authorizer/acls.proto ---------------------------------------------------------------------- diff --git a/include/mesos/authorizer/acls.proto b/include/mesos/authorizer/acls.proto index f8e866b..a6d93cd 100644 --- a/include/mesos/authorizer/acls.proto +++ b/include/mesos/authorizer/acls.proto @@ -27,10 +27,13 @@ option java_outer_classname = "Protos"; */ message ACL { // Entity is used to describe a subject(s) or an object(s) of an ACL. - // NOTE: - // To allow everyone access to an Entity set its type to 'ANY'. - // To deny access to an Entity set its type to 'NONE'. - // Entities in the messages should be 'required'. + // + // NOTE: To allow everyone access to an `Entity` set its type to + // `ANY`. To deny access to an `Entity` set its type to `NONE`. + // + // NOTE: When adding new actions to these proto definitions, + // declare entities in these messages as `required`. Absent + // `Entity` is ambiguous: it can be interpreted as `NONE` or `ANY`. message Entity { enum Type { SOME = 0;
