Repository: mesos Updated Branches: refs/heads/master e17deb66b -> 45fea2107
Windows: Disabled some deprecated function warnings. Visual Studio emits warnings for using deprecated functions in CRT and the use of insecure functions in CRT. This commit supresses the warning generation temporarily. Review: https://reviews.apache.org/r/51860/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/862da543 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/862da543 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/862da543 Branch: refs/heads/master Commit: 862da54368841adf23be83e0eddd050b20733948 Parents: e17deb6 Author: Daniel Pravat <dpra...@outlook.com> Authored: Fri Sep 16 17:03:32 2016 -0700 Committer: Joseph Wu <josep...@apache.org> Committed: Fri Sep 16 17:05:30 2016 -0700 ---------------------------------------------------------------------- cmake/CompilationConfigure.cmake | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/862da543/cmake/CompilationConfigure.cmake ---------------------------------------------------------------------- diff --git a/cmake/CompilationConfigure.cmake b/cmake/CompilationConfigure.cmake index 04e3ceb..11a8507 100644 --- a/cmake/CompilationConfigure.cmake +++ b/cmake/CompilationConfigure.cmake @@ -70,7 +70,7 @@ if (WIN32) # COFF/PE and friends are somewhat limited in the number of sections they # allow for an object file. We use this to avoid those problems. - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj -DGOOGLE_GLOG_DLL_DECL= -DCURL_STATICLIB -D_SCL_SECURE_NO_WARNINGS /vd2 /MP") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj -DGOOGLE_GLOG_DLL_DECL= -DCURL_STATICLIB /vd2 /MP") set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /MTd") set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT") @@ -96,6 +96,15 @@ if (WIN32) add_definitions(-DHAVE_LIBZ) endif (WIN32) +# Defines to disable warnings generated by Visual Studio when using +# deprecated functions in CRT and the use of insecure functions in CRT. +# TODO(dpravat): Once the entire codebase is changed to use secure CRT +# functions, these defines should be removed. +if (WIN32) + add_definitions(-D_SCL_SECURE_NO_WARNINGS) + add_definitions(-D_CRT_SECURE_NO_WARNINGS) + add_definitions(-D_CRT_NONSTDC_NO_WARNINGS) +endif (WIN32) # Configure directory structure for different platforms. ########################################################
