Consistently used virtual inheritance for Flags classes in libprocess. In order for different `Flags` classes to be composable classes should always use virtual inheritance.
Review: https://reviews.apache.org/r/52387/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/bb903381 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/bb903381 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/bb903381 Branch: refs/heads/master Commit: bb903381fa8b98c1f16bd8af69c727d501ba99e9 Parents: 16914ae Author: Benjamin Bannier <benjamin.bann...@mesosphere.io> Authored: Fri Oct 14 18:56:04 2016 -0400 Committer: Michael Park <mp...@apache.org> Committed: Mon Oct 17 05:34:41 2016 -0400 ---------------------------------------------------------------------- 3rdparty/libprocess/src/tests/subprocess_tests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/bb903381/3rdparty/libprocess/src/tests/subprocess_tests.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/tests/subprocess_tests.cpp b/3rdparty/libprocess/src/tests/subprocess_tests.cpp index 483ac1c..630a714 100644 --- a/3rdparty/libprocess/src/tests/subprocess_tests.cpp +++ b/3rdparty/libprocess/src/tests/subprocess_tests.cpp @@ -619,7 +619,7 @@ TEST_F(SubprocessTest, Default) #endif // __WINDOWS__ -struct Flags : public flags::FlagsBase +struct Flags : public virtual flags::FlagsBase { Flags() {