Fully qualified addresses of flag members in `add` calls in libprocess. While right now we can technically `add` variables to `Flags` classes which are not members, the in order to have correct copy semantics for `Flags` only member variables should be used.
Here we changed all instances to a full pointer-to-member syntax in the current code. Review: https://reviews.apache.org/r/46823/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/dde5eee7 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/dde5eee7 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/dde5eee7 Branch: refs/heads/master Commit: dde5eee7b11be8df874571316e29a9a25ae59150 Parents: 5aeecca Author: Benjamin Bannier <benjamin.bann...@mesosphere.io> Authored: Tue Oct 18 03:29:39 2016 -0400 Committer: Michael Park <mp...@apache.org> Committed: Tue Oct 18 04:28:39 2016 -0400 ---------------------------------------------------------------------- 3rdparty/libprocess/src/tests/subprocess_tests.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/dde5eee7/3rdparty/libprocess/src/tests/subprocess_tests.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/tests/subprocess_tests.cpp b/3rdparty/libprocess/src/tests/subprocess_tests.cpp index 630a714..0dc1c62 100644 --- a/3rdparty/libprocess/src/tests/subprocess_tests.cpp +++ b/3rdparty/libprocess/src/tests/subprocess_tests.cpp @@ -623,14 +623,14 @@ struct Flags : public virtual flags::FlagsBase { Flags() { - add(&b, "b", "bool"); - add(&i, "i", "int"); - add(&s, "s", "string"); - add(&s2, "s2", "string with single quote"); - add(&s3, "s3", "string with double quote"); - add(&d, "d", "Duration"); - add(&y, "y", "Bytes"); - add(&j, "j", "JSON::Object"); + add(&Flags::b, "b", "bool"); + add(&Flags::i, "i", "int"); + add(&Flags::s, "s", "string"); + add(&Flags::s2, "s2", "string with single quote"); + add(&Flags::s3, "s3", "string with double quote"); + add(&Flags::d, "d", "Duration"); + add(&Flags::y, "y", "Bytes"); + add(&Flags::j, "j", "JSON::Object"); } Option<bool> b;
