Transformed a fatal log message into a simple exit. The failures we see while validating flags in libprocess does not warrant printing a stack trace on validation error. The stack trace gives a false impression that something went wrong in libprocess, versus the user specifying an incorrect environment variable.
Review: https://reviews.apache.org/r/53560/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1fc0551d Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1fc0551d Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1fc0551d Branch: refs/heads/master Commit: 1fc0551db54cd4492c3772d68212b9d7c6571728 Parents: 1d33559 Author: Armand Grillet <armand.gril...@gmail.com> Authored: Wed Nov 23 13:21:34 2016 -0800 Committer: Joseph Wu <josep...@apache.org> Committed: Wed Nov 23 13:44:57 2016 -0800 ---------------------------------------------------------------------- 3rdparty/libprocess/src/process.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/1fc0551d/3rdparty/libprocess/src/process.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp index 7a7586b..e9a4bbb 100644 --- a/3rdparty/libprocess/src/process.cpp +++ b/3rdparty/libprocess/src/process.cpp @@ -1077,7 +1077,7 @@ bool initialize( Try<flags::Warnings> load = flags.load("LIBPROCESS_"); if (load.isError()) { - LOG(FATAL) << flags.usage(load.error()); + EXIT(EXIT_FAILURE) << flags.usage(load.error()); } // Log any flag warnings.
