Clarified comments in sorter. Review: https://reviews.apache.org/r/56349
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/c07f9285 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/c07f9285 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/c07f9285 Branch: refs/heads/master Commit: c07f9285d31cafc49033a9c1442d702d83914522 Parents: 2339f77 Author: Neil Conway <[email protected]> Authored: Mon Feb 6 12:05:53 2017 -0800 Committer: Neil Conway <[email protected]> Committed: Fri Feb 17 18:30:03 2017 -0800 ---------------------------------------------------------------------- src/master/allocator/sorter/drf/sorter.hpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/c07f9285/src/master/allocator/sorter/drf/sorter.hpp ---------------------------------------------------------------------- diff --git a/src/master/allocator/sorter/drf/sorter.hpp b/src/master/allocator/sorter/drf/sorter.hpp index 5bed53a..04d5ffc 100644 --- a/src/master/allocator/sorter/drf/sorter.hpp +++ b/src/master/allocator/sorter/drf/sorter.hpp @@ -143,7 +143,7 @@ private: // If true, sort() will recalculate all shares. bool dirty = false; - // A set of Clients (names and shares) sorted by share. + // The set of active clients (names and shares), sorted by share. std::set<Client, DRFComparator> clients; // Maps client names to the weights that should be applied to their shares. @@ -203,7 +203,9 @@ private: hashmap<std::string, Value::Scalar> totals; }; - // Maps client names to the resources they have been allocated. + // Maps client names to the resources they have been allocated. Note + // that `allocations` might contain entries for deactivated clients + // not currently in `clients`. hashmap<std::string, Allocation> allocations; // Metrics are optionally exposed by the sorter.
