Repository: mesos Updated Branches: refs/heads/master 5324b5999 -> dcae184eb
Updated the style guide with escape rules for IDs. Review: https://reviews.apache.org/r/57789 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/dcae184e Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/dcae184e Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/dcae184e Branch: refs/heads/master Commit: dcae184ebe939fd3c8346f01c1cfbd0b924dc920 Parents: 5324b59 Author: Alexander Rukletsov <[email protected]> Authored: Mon Mar 20 19:38:08 2017 +0100 Committer: Alexander Rukletsov <[email protected]> Committed: Mon Mar 20 19:40:31 2017 +0100 ---------------------------------------------------------------------- docs/c++-style-guide.md | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/dcae184e/docs/c++-style-guide.md ---------------------------------------------------------------------- diff --git a/docs/c++-style-guide.md b/docs/c++-style-guide.md index 18f716b..ccb81f4 100644 --- a/docs/c++-style-guide.md +++ b/docs/c++-style-guide.md @@ -52,6 +52,7 @@ void Slave::statusUpdate(StatusUpdate update, const UPID& pid) ## Strings * Strings used in log and error messages should end without a period. +* ID values in log and error messages should be enclosed in single quotes only if they might contain a space; this includes all IDs not generated by Mesos. ## Comments * End each sentence within a comment with a punctuation mark (please note that we generally prefer periods); this applies to incomplete sentences as well.
