Windows: Lowered logging level on fcntl.hpp helpers. On Windows, the `cloexec` and `nonblock` helpers are stubs or no-ops. Every call to these helpers prints a warning log, which ends up polluting the stderr output with basically meaningless warnings.
This commit moves these log messages to `VLOG(2)`. Based on the current set of features ported to Windows, these functions are "correct" in the sense that every FD is cloexec'd and nonblocking by default on Windows. Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/7ee317f8 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/7ee317f8 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/7ee317f8 Branch: refs/heads/master Commit: 7ee317f8a677a8aa6f7c8865db8fb915ed683733 Parents: cf5e7f9 Author: Joseph Wu <[email protected]> Authored: Fri Apr 7 13:27:21 2017 -0700 Committer: Joseph Wu <[email protected]> Committed: Fri Apr 7 13:27:27 2017 -0700 ---------------------------------------------------------------------- 3rdparty/stout/include/stout/os/windows/fcntl.hpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/7ee317f8/3rdparty/stout/include/stout/os/windows/fcntl.hpp ---------------------------------------------------------------------- diff --git a/3rdparty/stout/include/stout/os/windows/fcntl.hpp b/3rdparty/stout/include/stout/os/windows/fcntl.hpp index 825740b..ac90bf0 100644 --- a/3rdparty/stout/include/stout/os/windows/fcntl.hpp +++ b/3rdparty/stout/include/stout/os/windows/fcntl.hpp @@ -27,7 +27,7 @@ namespace os { // NOTE: This is not supported on Windows. inline Try<Nothing> cloexec(const WindowsFD& fd) { - LOG(WARNING) << "`os::cloexec` has been called, but is a no-op on Windows"; + VLOG(2) << "`os::cloexec` has been called, but is a no-op on Windows"; return Nothing(); } @@ -35,16 +35,14 @@ inline Try<Nothing> cloexec(const WindowsFD& fd) // NOTE: This is not supported on Windows. inline Try<Nothing> unsetCloexec(const WindowsFD& fd) { - LOG(WARNING) << "`os::unsetCloexec` has been called, " - << "but is a no-op on Windows"; - + VLOG(2) << "`os::unsetCloexec` has been called, but is a no-op on Windows"; return Nothing(); } inline Try<bool> isCloexec(const WindowsFD& fd) { - LOG(WARNING) << "`os::isCloexec` has been called, but is a stub on Windows"; + VLOG(2) << "`os::isCloexec` has been called, but is a stub on Windows"; return true; } @@ -75,7 +73,7 @@ inline Try<Nothing> nonblock(const WindowsFD& fd) // NOTE: This is not supported on Windows. inline Try<bool> isNonblock(const WindowsFD& fd) { - LOG(WARNING) << "`os::isNonblock` has been called, but is a stub on Windows"; + VLOG(2) << "`os::isNonblock` has been called, but is a stub on Windows"; return true; }
