Repository: mesos Updated Branches: refs/heads/master bd5e874c2 -> 772c8f554
Windows: Disable some new tests that fetch local URIs. Mesos currently conflates paths and URIs. On platforms where the path separator '\' is not equal to the URI separator '/', tests that rely on `path` helpers for URIs will naturally fail. This disables some new tests that fail on Windows for this reason. The tests here should eventually be fixed along with MESOS-6705. Review: https://reviews.apache.org/r/62735/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/772c8f55 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/772c8f55 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/772c8f55 Branch: refs/heads/master Commit: 772c8f554fe19f8c121c57bee97679cde2646fb8 Parents: bd5e874 Author: Gaston Kleiman <[email protected]> Authored: Mon Oct 2 16:27:32 2017 -0700 Committer: Joseph Wu <[email protected]> Committed: Mon Oct 2 16:41:58 2017 -0700 ---------------------------------------------------------------------- src/tests/default_executor_tests.cpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/772c8f55/src/tests/default_executor_tests.cpp ---------------------------------------------------------------------- diff --git a/src/tests/default_executor_tests.cpp b/src/tests/default_executor_tests.cpp index 63952d9..14dedab 100644 --- a/src/tests/default_executor_tests.cpp +++ b/src/tests/default_executor_tests.cpp @@ -1374,7 +1374,10 @@ struct LauncherAndIsolationParam // This test verifies that URIs set on tasks are fetched and made available to // them when started by the DefaultExecutor. -TEST_P(DefaultExecutorTest, TaskWithFileURI) +// +// TODO(josephw): Reenable this test once URIs are constructed without using +// the `path` helpers. This should be fixed along with MESOS-6705. +TEST_P_TEMP_DISABLED_ON_WINDOWS(DefaultExecutorTest, TaskWithFileURI) { Try<Owned<cluster::Master>> master = StartMaster(); ASSERT_SOME(master); @@ -1471,7 +1474,11 @@ TEST_P(DefaultExecutorTest, TaskWithFileURI) // This test verifies that URIs set on Docker tasks are fetched and made // available to them when started by the DefaultExecutor. -TEST_P(DefaultExecutorTest, ROOT_INTERNET_CURL_DockerTaskWithFileURI) +// +// TODO(josephw): Reenable this test once URIs are constructed without using +// the `path` helpers. This should be fixed along with MESOS-6705. +TEST_P_TEMP_DISABLED_ON_WINDOWS( + DefaultExecutorTest, ROOT_INTERNET_CURL_DockerTaskWithFileURI) { Try<Owned<cluster::Master>> master = StartMaster(); ASSERT_SOME(master);
