Repository: mesos Updated Branches: refs/heads/master 2e83009ef -> 6dfb749c9
Fixed incorrect testing of existence of variables. The following was committed in response to a Javascript linter, but the corresponding change was incorrect. https://github.com/apache/mesos/commit/af8404e Specifically: ``` - page_size || $.error('Expecting page_size to be defined'); - truncate_length || $.error('Expecting truncate_length to be defined'); + if (page_size) { + $.error('Expecting page_size to be defined') + } + + if (truncate_length) { + $.error('Expecting truncate_length to be defined') + } ``` Review: https://reviews.apache.org/r/64391/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/6dfb749c Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/6dfb749c Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/6dfb749c Branch: refs/heads/master Commit: 6dfb749c9be9f8af224a15fa057412fe0fa8a17d Parents: 2e83009 Author: Michael Park <[email protected]> Authored: Wed Dec 6 12:29:59 2017 -0800 Committer: Michael Park <[email protected]> Committed: Wed Dec 6 12:31:00 2017 -0800 ---------------------------------------------------------------------- src/webui/master/static/js/jquery.pailer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/6dfb749c/src/webui/master/static/js/jquery.pailer.js ---------------------------------------------------------------------- diff --git a/src/webui/master/static/js/jquery.pailer.js b/src/webui/master/static/js/jquery.pailer.js index 93ff04b..884e282 100644 --- a/src/webui/master/static/js/jquery.pailer.js +++ b/src/webui/master/static/js/jquery.pailer.js @@ -87,11 +87,11 @@ this_.paging = false; this_.tailing = true; - if (page_size) { + if (!page_size) { $.error('Expecting page_size to be defined') } - if (truncate_length) { + if (!truncate_length) { $.error('Expecting truncate_length to be defined') }
