Repository: mesos Updated Branches: refs/heads/master e7d1db246 -> b780d873b
Windows: Enabled remaining `FlagsTests`. This resolve MESOS-3437 trivially because MESOS-5880 and MESOS-5937 have since been resolved. This replaces review 63239 because the final iteration was not right. Review: https://reviews.apache.org/r/64432 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b780d873 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b780d873 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b780d873 Branch: refs/heads/master Commit: b780d873b4326747fac7d7aa01303642d3b1512d Parents: e7d1db2 Author: Andrew Schwartzmeyer <[email protected]> Authored: Thu Dec 7 16:17:29 2017 -0800 Committer: Andrew Schwartzmeyer <[email protected]> Committed: Mon Dec 11 12:50:18 2017 -0800 ---------------------------------------------------------------------- 3rdparty/stout/tests/flags_tests.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/b780d873/3rdparty/stout/tests/flags_tests.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/stout/tests/flags_tests.cpp b/3rdparty/stout/tests/flags_tests.cpp index 88c8ee5..60ed8eb 100644 --- a/3rdparty/stout/tests/flags_tests.cpp +++ b/3rdparty/stout/tests/flags_tests.cpp @@ -226,10 +226,7 @@ TEST(FlagsTest, Flags) } -// TODO(hausdorff): Enable this test on Windows. Currently setting an -// environment variable to the blank string will cause the environment variable -// to be deleted on Windows. See MESOS-5880. -TEST_TEMP_DISABLED_ON_WINDOWS(FlagsTest, LoadFromEnvironment) +TEST(FlagsTest, LoadFromEnvironment) { TestFlagsBase flags; @@ -524,9 +521,7 @@ TEST(FlagsTest, DeprecationWarning) } -// TODO(hausdorff): Enable this test on Windows. Currently `flags::parse` -// assumes filesystems are rooted at '/'. See MESOS-5937. -TEST_TEMP_DISABLED_ON_WINDOWS(FlagsTest, DuplicatesFromEnvironment) +TEST(FlagsTest, DuplicatesFromEnvironment) { TestFlagsBase flags;
