Windows: Removed `/debug:fastlink` linker flag. With Visual Studio 2017, `fastlink` is now the default, so this is superfluous. Morever, this particular CMake variable also passes the flag to `lib.exe` when generating a static library, and this emits a warning because `lib.exe` does not accept this flag. It was intended to be sent to the `link.exe` linker, and so should not have included `STATIC` in the list of types.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d9568667 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d9568667 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d9568667 Branch: refs/heads/master Commit: d95686674445d75f3ebd9d69fd42dd5cb84b3bdb Parents: 9ac9156 Author: Andrew Schwartzmeyer <[email protected]> Authored: Wed Dec 13 15:31:35 2017 -0800 Committer: Andrew Schwartzmeyer <[email protected]> Committed: Fri Dec 15 15:57:56 2017 -0800 ---------------------------------------------------------------------- cmake/CompilationConfigure.cmake | 6 ------ 1 file changed, 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/d9568667/cmake/CompilationConfigure.cmake ---------------------------------------------------------------------- diff --git a/cmake/CompilationConfigure.cmake b/cmake/CompilationConfigure.cmake index 854e3c9..dc9dc16 100644 --- a/cmake/CompilationConfigure.cmake +++ b/cmake/CompilationConfigure.cmake @@ -264,12 +264,6 @@ string(COMPARE EQUAL ${CMAKE_SYSTEM_NAME} "Linux" LINUX) # WINDOWS CONFIGURATION. ######################## if (WIN32) - # Speed up incremental linking for the VS compiler/linker, for more info, see: - # https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ - foreach (type EXE SHARED STATIC MODULE) - string(APPEND CMAKE_${type}_LINKER_FLAGS_DEBUG " /debug:fastlink") - endforeach () - # COFF/PE and friends are somewhat limited in the number of sections they # allow for an object file. We use this to avoid those problems. string(APPEND CMAKE_CXX_FLAGS " /bigobj /vd2 /permissive-")
