Repository: mesos
Updated Branches:
  refs/heads/1.4.x a6a8b1ca3 -> 6199905ec


Promoted log level to warning for disconnected events in exec.cpp.

When the executor library receives messages while being disconnected,
it might indicate an out-of-order message delivery or lost messages.
This should be logged at the warning level to simplify triaging.

Review: https://reviews.apache.org/r/64032/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2e7a772f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2e7a772f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2e7a772f

Branch: refs/heads/1.4.x
Commit: 2e7a772f171498874a4e5a56e3066fd5e95e2bec
Parents: a6a8b1c
Author: Alexander Rukletsov <ruklet...@gmail.com>
Authored: Fri Dec 22 12:09:58 2017 +0100
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Fri Dec 22 12:29:23 2017 +0100

----------------------------------------------------------------------
 src/exec/exec.cpp | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/2e7a772f/src/exec/exec.cpp
----------------------------------------------------------------------
diff --git a/src/exec/exec.cpp b/src/exec/exec.cpp
index 65c4575..ea0b118 100644
--- a/src/exec/exec.cpp
+++ b/src/exec/exec.cpp
@@ -209,8 +209,7 @@ public:
 protected:
   virtual void initialize()
   {
-    VLOG(1) << "Executor started at: " << self()
-            << " with pid " << getpid();
+    VLOG(1) << "Executor started at: " << self() << " with pid " << getpid();
 
     link(slave);
 
@@ -318,8 +317,8 @@ protected:
     }
 
     if (!connected) {
-      VLOG(1) << "Ignoring run task message for task " << task.task_id()
-              << " because the driver is disconnected!";
+      LOG(WARNING) << "Ignoring run task message for task " << task.task_id()
+                   << " because the driver is disconnected!";
       return;
     }
 
@@ -378,10 +377,10 @@ protected:
     }
 
     if (!connected) {
-      VLOG(1) << "Ignoring status update acknowledgement "
-              << uuid_.get() << " for task " << taskId
-              << " of framework " << frameworkId
-              << " because the driver is disconnected!";
+      LOG(WARNING) << "Ignoring status update acknowledgement "
+                   << uuid_.get() << " for task " << taskId
+                   << " of framework " << frameworkId
+                   << " because the driver is disconnected!";
       return;
     }
 
@@ -408,8 +407,8 @@ protected:
     }
 
     if (!connected) {
-      VLOG(1) << "Ignoring framework message because "
-              << "the driver is disconnected!";
+      LOG(WARNING) << "Ignoring framework message because"
+                   << " the driver is disconnected!";
       return;
     }
 

Reply via email to