Repository: mesos Updated Branches: refs/heads/master 6e9a7a019 -> 24317f9d1
Removed a stale TODO in the allocator. This TODO was added when we used to skip roles with satisfied quota during the first phase of allocation. We no longer do this since we now allocate reservations for these roles. Review: https://reviews.apache.org/r/64765 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/24317f9d Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/24317f9d Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/24317f9d Branch: refs/heads/master Commit: 24317f9d12757310b92d82b8a9bcd39a956b678d Parents: 6e9a7a0 Author: Benjamin Mahler <[email protected]> Authored: Wed Dec 20 19:47:32 2017 -0800 Committer: Benjamin Mahler <[email protected]> Committed: Fri Dec 22 15:27:22 2017 -0800 ---------------------------------------------------------------------- src/master/allocator/mesos/hierarchical.cpp | 5 ----- 1 file changed, 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/24317f9d/src/master/allocator/mesos/hierarchical.cpp ---------------------------------------------------------------------- diff --git a/src/master/allocator/mesos/hierarchical.cpp b/src/master/allocator/mesos/hierarchical.cpp index 20e0b29..5697edc 100644 --- a/src/master/allocator/mesos/hierarchical.cpp +++ b/src/master/allocator/mesos/hierarchical.cpp @@ -1759,11 +1759,6 @@ void HierarchicalAllocatorProcess::__allocate() // If quota for the role is considered satisfied, then we only // further allocate reservations for the role. // - // TODO(alexr): Skipping satisfied roles is pessimistic. Better - // alternatives are: - // * A custom sorter that is aware of quotas and sorts accordingly. - // * Removing satisfied roles from the sorter. - // // This is a scalar quantity with no meta-data. Resources unsatisfiedQuota = Resources(quota.info.guarantee()) - resourcesChargedAgainstQuota;
