Repository: mesos Updated Branches: refs/heads/master 71160110b -> 39d917cc0
Added a TODO for informing frameworks that an agent is unreachable. Currently, we tell partition aware frameworks that unreachable agents are LOST. Ideally the partition awareness change would have included agent unreachability information rather than only task unreachability information. Review: https://reviews.apache.org/r/64931 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/39d917cc Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/39d917cc Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/39d917cc Branch: refs/heads/master Commit: 39d917cc066f0fe1f74c11ecfff6f41c765b2fd3 Parents: 74b2a0b Author: Benjamin Mahler <[email protected]> Authored: Wed Jan 3 14:11:54 2018 -0800 Committer: Benjamin Mahler <[email protected]> Committed: Wed Jan 10 14:44:20 2018 -0800 ---------------------------------------------------------------------- src/master/master.cpp | 6 ++++++ 1 file changed, 6 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/39d917cc/src/master/master.cpp ---------------------------------------------------------------------- diff --git a/src/master/master.cpp b/src/master/master.cpp index daf2f7e..7ed15e4 100644 --- a/src/master/master.cpp +++ b/src/master/master.cpp @@ -8242,6 +8242,9 @@ void Master::_markUnreachable( ++metrics->recovery_slave_removals; + // TODO(bmahler): Tell partition aware frameworks that the + // agent is unreachable rather than lost. This requires a + // new capability. sendSlaveLost(slave); } else { CHECK(slaves.registered.contains(slave.id())); @@ -10084,6 +10087,9 @@ void Master::__removeSlave( // TODO(benh): unlink(slave->pid); + // TODO(bmahler): Tell partition aware frameworks that the + // agent is unreachable rather than lost, if applicable. + // This requires a new capability. sendSlaveLost(slave->info); delete slave;
