Logged some additional information on a master CHECK. If the master attempts to remove an unreachable task on a registered agent, log some additional debugging information in the CHECK to help track down what happened.
Review: https://reviews.apache.org/r/65143/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/9ecfb4ae Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/9ecfb4ae Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/9ecfb4ae Branch: refs/heads/master Commit: 9ecfb4aecd081ac9a74cdf2c71ec1565bf242e16 Parents: 364e78a Author: James Peach <[email protected]> Authored: Fri Jan 12 17:01:48 2018 -0800 Committer: Gilbert Song <[email protected]> Committed: Fri Jan 12 17:01:48 2018 -0800 ---------------------------------------------------------------------- src/master/master.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/9ecfb4ae/src/master/master.cpp ---------------------------------------------------------------------- diff --git a/src/master/master.cpp b/src/master/master.cpp index b0ec565..341881b 100644 --- a/src/master/master.cpp +++ b/src/master/master.cpp @@ -9545,7 +9545,10 @@ void Master::removeFramework(Framework* framework) // We don't need to remove the task from the slave, because the // task was removed when the agent was marked unreachable. - CHECK(!slaves.registered.contains(task->slave_id())); + CHECK(!slaves.registered.contains(task->slave_id())) + << "Unreachable task " << task->task_id() + << " of framework " << task->framework_id() + << " was found on registered agent " << task->slave_id(); // Move task from unreachable map to completed map. framework->addCompletedTask(std::move(*task));
