Repository: mesos
Updated Branches:
  refs/heads/1.5.x 35ac2f047 -> 336b067be


Logged some additional information on a master CHECK.

If the master attempts to remove an unreachable task on a registered
agent, log some additional debugging information in the CHECK to help
track down what happened.

Review: https://reviews.apache.org/r/65143/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/336b067b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/336b067b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/336b067b

Branch: refs/heads/1.5.x
Commit: 336b067be8e864f751c292152edf4cb1461e7ce1
Parents: 0f05e05
Author: James Peach <jpe...@apache.org>
Authored: Fri Jan 12 17:01:48 2018 -0800
Committer: Gilbert Song <songzihao1...@gmail.com>
Committed: Fri Jan 12 17:04:19 2018 -0800

----------------------------------------------------------------------
 src/master/master.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/336b067b/src/master/master.cpp
----------------------------------------------------------------------
diff --git a/src/master/master.cpp b/src/master/master.cpp
index a6be5a9..e169a60 100644
--- a/src/master/master.cpp
+++ b/src/master/master.cpp
@@ -9539,7 +9539,10 @@ void Master::removeFramework(Framework* framework)
 
     // We don't need to remove the task from the slave, because the
     // task was removed when the agent was marked unreachable.
-    CHECK(!slaves.registered.contains(task->slave_id()));
+    CHECK(!slaves.registered.contains(task->slave_id()))
+      << "Unreachable task " << task->task_id()
+      << " of framework " << task->framework_id()
+      << " was found on registered agent " << task->slave_id();
 
     // Move task from unreachable map to completed map.
     framework->addCompletedTask(std::move(*task));

Reply via email to