Repository: mesos Updated Branches: refs/heads/1.5.x 667c77485 -> 0a1a345bd
Marked volume/block creation and destroy operations as experimental. This patch marks the `CREATE_VOLUME`, `DESTROY_VOLUME`, `CREATE_BLOCK` and `DESTROY_BLOCK` as experimental APIs. It also unifies the way we mark experimental APIs. Review: https://reviews.apache.org/r/66616/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/65254060 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/65254060 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/65254060 Branch: refs/heads/1.5.x Commit: 652540602bdf2f56b683018211288dd1ba4be780 Parents: 667c774 Author: Chun-Hung Hsiao <[email protected]> Authored: Tue Apr 17 18:38:38 2018 -0700 Committer: Chun-Hung Hsiao <[email protected]> Committed: Tue Apr 17 18:49:05 2018 -0700 ---------------------------------------------------------------------- include/mesos/mesos.proto | 22 +++++++++++++++------- include/mesos/v1/mesos.proto | 22 +++++++++++++++------- 2 files changed, 30 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/65254060/include/mesos/mesos.proto ---------------------------------------------------------------------- diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto index 01b05f9..a147ce2 100644 --- a/include/mesos/mesos.proto +++ b/include/mesos/mesos.proto @@ -419,7 +419,7 @@ message FrameworkInfo { * specifying one of the optional fields. Specifying more than one type * is an error. * - * NOTE: This API is unstable and the related feature is experimental. + * NOTE: This API is subject to change and the related feature is experimental. */ message CheckInfo { enum Type { @@ -1917,10 +1917,10 @@ message Offer { UNRESERVE = 3; CREATE = 4; DESTROY = 5; - CREATE_VOLUME = 7; - DESTROY_VOLUME = 8; - CREATE_BLOCK = 9; - DESTROY_BLOCK = 10; + CREATE_VOLUME = 7; // EXPERIMENTAL. + DESTROY_VOLUME = 8; // EXPERIMENTAL. + CREATE_BLOCK = 9; // EXPERIMENTAL. + DESTROY_BLOCK = 10; // EXPERIMENTAL. } // TODO(vinod): Deprecate this in favor of `LaunchGroup` below. @@ -1957,19 +1957,27 @@ message Offer { repeated Resource volumes = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateVolume { required Resource source = 1; required Resource.DiskInfo.Source.Type target_type = 2; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyVolume { required Resource volume = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateBlock { required Resource source = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyBlock { required Resource block = 1; } @@ -1979,7 +1987,7 @@ message Offer { // NOTE: The `id` field will allow frameworks to indicate that they wish to // receive feedback about an operation. Since this feature is not yet // implemented, the `id` field should NOT be set at present. See MESOS-8054. - optional OperationID id = 12; // Experimental. + optional OperationID id = 12; // EXPERIMENTAL. optional Launch launch = 2; optional LaunchGroup launch_group = 7; @@ -2327,7 +2335,7 @@ message OperationStatus { * (e.g., the check timed out), these fields must contain empty messages, i.e., * `exit_code` or `status_code` will be unset. * -* NOTE: This API is unstable and the related feature is experimental. +* NOTE: This API is subject to change and the related feature is experimental. */ message CheckStatusInfo { message Command { http://git-wip-us.apache.org/repos/asf/mesos/blob/65254060/include/mesos/v1/mesos.proto ---------------------------------------------------------------------- diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto index ad7dd2d..ce3b31e 100644 --- a/include/mesos/v1/mesos.proto +++ b/include/mesos/v1/mesos.proto @@ -417,7 +417,7 @@ message FrameworkInfo { * specifying one of the optional fields. Specifying more than one type * is an error. * - * NOTE: This API is unstable and the related feature is experimental. + * NOTE: This API is subject to change and the related feature is experimental. */ message CheckInfo { enum Type { @@ -1909,10 +1909,10 @@ message Offer { UNRESERVE = 3; CREATE = 4; DESTROY = 5; - CREATE_VOLUME = 7; - DESTROY_VOLUME = 8; - CREATE_BLOCK = 9; - DESTROY_BLOCK = 10; + CREATE_VOLUME = 7; // EXPERIMENTAL. + DESTROY_VOLUME = 8; // EXPERIMENTAL. + CREATE_BLOCK = 9; // EXPERIMENTAL. + DESTROY_BLOCK = 10; // EXPERIMENTAL. } // TODO(vinod): Deprecate this in favor of `LaunchGroup` below. @@ -1949,19 +1949,27 @@ message Offer { repeated Resource volumes = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateVolume { required Resource source = 1; required Resource.DiskInfo.Source.Type target_type = 2; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyVolume { required Resource volume = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateBlock { required Resource source = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyBlock { required Resource block = 1; } @@ -1971,7 +1979,7 @@ message Offer { // NOTE: The `id` field will allow frameworks to indicate that they wish to // receive feedback about an operation. Since this feature is not yet // implemented, the `id` field should NOT be set at present. See MESOS-8054. - optional OperationID id = 12; // Experimental. + optional OperationID id = 12; // EXPERIMENTAL. optional Launch launch = 2; optional LaunchGroup launch_group = 7; @@ -2319,7 +2327,7 @@ message OperationStatus { * (e.g., the check timed out), these fields must contain empty messages, i.e., * `exit_code` or `status_code` will be unset. * -* NOTE: This API is unstable and the related feature is experimental. +* NOTE: This API is subject to change and the related feature is experimental. */ message CheckStatusInfo { message Command {
