Windows: Fixed build with OpenSSL due to missing header. When `-DENABLE_SSL=TRUE`, then `USE_SSL_SOCKET` is defined, and in this `src/local/local.cpp` in a section guarded by said definition, the construct `os::Permissions` is used. However, this is defined in `stout/os/permissions.hpp`, which is implicitly included on POSIX, but not on Windows. The fix is to IWYU and explicitly include it.
Review: https://reviews.apache.org/r/66753/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/654e5984 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/654e5984 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/654e5984 Branch: refs/heads/master Commit: 654e5984f100ab8b52c87506a66eea9630e54a8f Parents: 12a907b Author: Andrew Schwartzmeyer <[email protected]> Authored: Fri Apr 20 18:39:35 2018 -0700 Committer: Chun-Hung Hsiao <[email protected]> Committed: Fri Apr 20 18:39:35 2018 -0700 ---------------------------------------------------------------------- src/local/local.cpp | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/654e5984/src/local/local.cpp ---------------------------------------------------------------------- diff --git a/src/local/local.cpp b/src/local/local.cpp index 9c5b45b..afff546 100644 --- a/src/local/local.cpp +++ b/src/local/local.cpp @@ -57,6 +57,10 @@ #include <stout/strings.hpp> #ifdef USE_SSL_SOCKET +#include <stout/os/permissions.hpp> +#endif // USE_SSL_SOCKET + +#ifdef USE_SSL_SOCKET #include "authentication/executor/jwt_secret_generator.hpp" #endif // USE_SSL_SOCKET
