Repository: mesos Updated Branches: refs/heads/master a1c6a7a3c -> ac4d52d89
Windows: Documented GNU patch's error if line endings are wrong. While the step necessary to prevent the error was documented, it was easy to skip, and moreover, the error message from GNU patch is entirely unhelpful in resolving the problem. Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ac4d52d8 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/ac4d52d8 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/ac4d52d8 Branch: refs/heads/master Commit: ac4d52d89e3164353aee946fb4f8e56a0c908a03 Parents: a1c6a7a Author: Andrew Schwartzmeyer <[email protected]> Authored: Wed Apr 25 11:43:50 2018 -0700 Committer: Andrew Schwartzmeyer <[email protected]> Committed: Wed Apr 25 11:45:30 2018 -0700 ---------------------------------------------------------------------- docs/windows.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/ac4d52d8/docs/windows.md ---------------------------------------------------------------------- diff --git a/docs/windows.md b/docs/windows.md index 101ae45..635c62c 100644 --- a/docs/windows.md +++ b/docs/windows.md @@ -23,7 +23,10 @@ Mesos 1.0.0 introduced experimental support for Windows. 4. If building from source, install [Git](https://git-scm.com/download/win). During installation, keep the defaults to "Use Git from the Windows Command Prompt", and "Checkout Windows-style, commit Unix-style - line endings" (i.e. `git config core.autocrlf true`). + line endings" (i.e. `git config --global core.autocrlf true`). The + last part is _very_ important, because GNU patch will crash with + "Assertion failed, hunk, file patch.c, line 343" if the patch files + on Windows are Unix-style (LF) instead of Windows-style (CRLF). 5. Make sure there are no spaces in your build directory. For example, `C:/Program Files (x86)/mesos` is an invalid build directory.
