Repository: mesos Updated Branches: refs/heads/master 36522a29a -> 44c132182
Disabled debug mode for libevent. Debug mode enables additional tracking in libevent to check for common errors. It is recommended to "only enable debug mode when actually debugging your program" because "tracking which events are initialized requires that Libevent use extra memory and CPU". http://www.wangafu.net/~nickm/libevent-book/Ref1_libsetup.html We could consider introducing libevent flags in order to be able to toggle this behavior with an environment variable since it appears that libevent does not provide one. However, since I don't believe these assertions have been of value, we can just remove the debug mode for now. Review: https://reviews.apache.org/r/66978 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/44c13218 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/44c13218 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/44c13218 Branch: refs/heads/master Commit: 44c1321827e25a2ee2210954b7d180bca8cf5232 Parents: 0262b41 Author: Benjamin Mahler <[email protected]> Authored: Sun May 6 19:03:07 2018 -0700 Committer: Benjamin Mahler <[email protected]> Committed: Mon May 7 14:17:16 2018 -0700 ---------------------------------------------------------------------- 3rdparty/libprocess/src/libevent.cpp | 4 ---- 1 file changed, 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/44c13218/3rdparty/libprocess/src/libevent.cpp ---------------------------------------------------------------------- diff --git a/3rdparty/libprocess/src/libevent.cpp b/3rdparty/libprocess/src/libevent.cpp index 20fc99c..fb595bc 100644 --- a/3rdparty/libprocess/src/libevent.cpp +++ b/3rdparty/libprocess/src/libevent.cpp @@ -199,10 +199,6 @@ void EventLoop::initialize() #error "Libevent must be compiled with either pthread or Windows thread support" #endif - // This enables debugging of libevent calls. We can remove this - // when the implementation settles and after we gain confidence. - event_enable_debug_mode(); - base = event_base_new(); if (base == nullptr) {
