Repository: mesos
Updated Branches:
  refs/heads/master 73bde5625 -> 44856413f


Windows: Disabled broken benchmarks test.

After updating to Visual Studio 15.7.1, this code no longer compiles.

It errors with:

> benchmarks.cpp(566): error C2276: '&': illegal operation on bound
> member function expression

> benchmarks.cpp(566): note: This diagnostic occurred in the compiler
> generated function 'process::Future<Nothing>
> DispatchProcess::handler(const T &)'

That is, the compiler is (now) complaining that `&Self::handler<T>` in
`DispatchProcess::handler()` is invalid.

Review: https://reviews.apache.org/r/67120


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/44856413
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/44856413
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/44856413

Branch: refs/heads/master
Commit: 44856413fc1099783263b3935ee3c995c9358aff
Parents: 73bde56
Author: Andrew Schwartzmeyer <[email protected]>
Authored: Mon May 14 15:37:35 2018 -0700
Committer: Andrew Schwartzmeyer <[email protected]>
Committed: Mon May 14 15:40:58 2018 -0700

----------------------------------------------------------------------
 3rdparty/libprocess/src/tests/benchmarks.cpp | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/44856413/3rdparty/libprocess/src/tests/benchmarks.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/tests/benchmarks.cpp 
b/3rdparty/libprocess/src/tests/benchmarks.cpp
index 1368375..0cdb132 100644
--- a/3rdparty/libprocess/src/tests/benchmarks.cpp
+++ b/3rdparty/libprocess/src/tests/benchmarks.cpp
@@ -495,6 +495,8 @@ TEST(ProcessTest, Process_BENCHMARK_ThroughputPerformance)
 }
 
 
+// TODO(andschwa): Turn this test back on when MESOS-8915 is solved.
+#ifndef __WINDOWS__
 class DispatchProcess : public Process<DispatchProcess>
 {
 public:
@@ -579,6 +581,7 @@ TEST(ProcessTest, Process_BENCHMARK_DispatchDefer)
   DispatchProcess::run<DispatchProcess::Movable>("Movable", repeats);
   DispatchProcess::run<DispatchProcess::Copyable>("Copyable", repeats);
 }
+#endif // __WINDOWS__
 
 
 class ProtobufInstallHandlerBenchmarkProcess

Reply via email to