This is an automated email from the ASF dual-hosted git repository. chhsiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 1b21b0de2fb2958a71d01acdd0dabbc52cf14ab2 Author: Chun-Hung Hsiao <[email protected]> AuthorDate: Fri Jan 4 15:40:25 2019 -0800 Always build gRPC with its embedded c-ares. We compile gRPC with its embedded c-ares library to avoid a link error because Mesos is not aware of the library. Review: https://reviews.apache.org/r/69671 --- 3rdparty/Makefile.am | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/3rdparty/Makefile.am b/3rdparty/Makefile.am index 9e9a37a..650a40f 100644 --- a/3rdparty/Makefile.am +++ b/3rdparty/Makefile.am @@ -466,8 +466,13 @@ $(LIB_GRPC): $(GRPC)-build-stamp # flags, which will be overwritten by the command line. See: # https://www.gnu.org/software/make/manual/html_node/Target_002dspecific.html # -# We use EXTRA_CPPFLAGS to pass `-Wno-error`, because that one needs to be +# NOTE: We use EXTRA_CPPFLAGS to pass `-Wno-error`, because that one needs to be # appended and not prepended to the constructed flags. +# +# NOTE: We compile gRPC with its embedded c-ares library to avoid a link error +# because Mesos is not aware of the library; see MESOS-9505. If bundle c-ares +# to resolve MESOS-9338 in the future, we should remove `HAS_SYSTEM_CARES` below +# and set up proper include and linker flags instead. $(GRPC)-build-stamp: $(GRPC)-stamp \ $(PROTOBUF)-build-stamp cd $(GRPC) && \ @@ -490,6 +495,7 @@ $(GRPC)-build-stamp: $(GRPC)-stamp \ $(LDFLAGS)" \ LDLIBS="$(LDLIBS)" \ HAS_PKG_CONFIG=false \ + HAS_SYSTEM_CARES=false \ NO_PROTOC=false \ PROTOC="$(PROTOC)" touch $@
