This is an automated email from the ASF dual-hosted git repository. bbannier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mesos.git
commit ddec46003da2017564f74eb5718b99cbc1da10f7 Author: Benjamin Bannier <[email protected]> AuthorDate: Mon Mar 4 09:02:48 2019 +0100 Addressed issues flagged by pylint-2.3.1. Review: https://reviews.apache.org/r/70090/ --- src/python/cli_new/lib/cli/exceptions.py | 1 - src/python/lib/mesos/http.py | 4 ++-- support/common.py | 1 - support/verify-reviews.py | 9 ++++----- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/python/cli_new/lib/cli/exceptions.py b/src/python/cli_new/lib/cli/exceptions.py index c78f4a9..e234f4a 100644 --- a/src/python/cli_new/lib/cli/exceptions.py +++ b/src/python/cli_new/lib/cli/exceptions.py @@ -22,4 +22,3 @@ class CLIException(Exception): """ Exceptions class to handle all CLI errors. """ - pass diff --git a/src/python/lib/mesos/http.py b/src/python/lib/mesos/http.py index 5a8016d..445568c 100644 --- a/src/python/lib/mesos/http.py +++ b/src/python/lib/mesos/http.py @@ -217,8 +217,8 @@ class Resource(): known_exception = self.ERROR_CODE_MAP.get(response.status_code) if known_exception: raise known_exception(response) - else: - raise MesosHTTPException(response) + + raise MesosHTTPException(response) def request(self, method, diff --git a/support/common.py b/support/common.py index 845a687..18ebccd 100644 --- a/support/common.py +++ b/support/common.py @@ -32,7 +32,6 @@ REVIEWBOARD_URL = "https://reviews.apache.org"; class ReviewError(Exception): """Custom exception raised when a review is bad""" - pass class ReviewBoardHandler(): diff --git a/support/verify-reviews.py b/support/verify-reviews.py index 377792d..c9c85f9 100755 --- a/support/verify-reviews.py +++ b/support/verify-reviews.py @@ -112,7 +112,6 @@ SKIP_VERIFY = parameters.skip_verify class ReviewError(Exception): """Exception returned by post_review().""" - pass def parse_time(timestamp): @@ -176,8 +175,8 @@ def apply_reviews(review_request, reviews): raise ReviewError( "Circular dependency detected for review %s." "Please fix the 'depends_on' field." % review_request["id"]) - else: - reviews.append(review_request["id"]) + + reviews.append(review_request["id"]) # First recursively apply the dependent reviews. for review in review_request["depends_on"]: @@ -196,8 +195,8 @@ def apply_reviews(review_request, reviews): error = err.output.decode("utf-8") if "patch does not apply" in error: raise ReviewError(error) - else: - raise err + + raise err def post_review(review_request, message):
