This is an automated email from the ASF dual-hosted git repository. bbannier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mesos.git
commit a48cfe1e53cc75501679e63b2622bbf719b5aaf4 Author: Benjamin Bannier <[email protected]> AuthorDate: Sat Mar 2 22:41:29 2019 +0100 Moved NULL check from cpplint into clang-tidy. Review: https://reviews.apache.org/r/70102 --- support/clang-tidy | 1 + support/cpplint.py | 5 ----- support/mesos-style.py | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/support/clang-tidy b/support/clang-tidy index d448314..8cb1662 100644 --- a/support/clang-tidy +++ b/support/clang-tidy @@ -29,6 +29,7 @@ mesos-*,\ \ misc-use-after-move,\ \ +modernize-use-nullptr,\ modernize-use-override,\ \ readability-redundant-string-cstr\ diff --git a/support/cpplint.py b/support/cpplint.py index 553ac1d..66ec8b3 100644 --- a/support/cpplint.py +++ b/support/cpplint.py @@ -239,7 +239,6 @@ _ERROR_CATEGORIES = [ 'build/include_order', 'build/include_what_you_use', 'build/namespaces', - 'build/nullptr', 'build/printf_format', 'build/storage_class', 'legal/copyright', @@ -4430,10 +4429,6 @@ def CheckStyle(filename, clean_lines, linenum, file_extension, nesting_state, error(filename, linenum, 'whitespace/newline', 0, 'More than one command on the same line') - if re.search(r'\bNULL\b', cleansed_line): - error(filename, linenum, 'build/nullptr', 1, - 'NULL found; better to use nullptr') - # Some more style checks CheckBraces(filename, clean_lines, linenum, error) CheckTrailingSemicolon(filename, clean_lines, linenum, error) diff --git a/support/mesos-style.py b/support/mesos-style.py index 22793cf..cd490bd 100755 --- a/support/mesos-style.py +++ b/support/mesos-style.py @@ -265,7 +265,6 @@ class CppLinter(LinterBase): 'build/class', 'build/deprecated', 'build/endif_comment', - 'build/nullptr', 'readability/todo', 'readability/namespace', 'runtime/vlog',
