This is an automated email from the ASF dual-hosted git repository.
grag pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 8558115 Updated protobuf comments related to operation feedback.
8558115 is described below
commit 85581157615351fb891fe1b0d25f20d918e6aedf
Author: Greg Mann <[email protected]>
AuthorDate: Wed Mar 13 11:11:41 2019 -0700
Updated protobuf comments related to operation feedback.
While the `id` field in `Offer::Operation` was previously marked
experimental, it is also wise to explicitly mark the related
scheduler API calls and events as experimental to avoid any
confusion.
Review: https://reviews.apache.org/r/70186/
---
include/mesos/mesos.proto | 6 +++---
include/mesos/scheduler/scheduler.proto | 6 ++++++
include/mesos/v1/mesos.proto | 6 +++---
include/mesos/v1/scheduler/scheduler.proto | 8 ++++++++
4 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 0998732..5f6e2c4 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -2124,9 +2124,9 @@ message Offer {
optional Type type = 1;
- // NOTE: The `id` field will allow frameworks to indicate that they wish to
- // receive feedback about an operation. Since this feature is not yet
- // implemented, the `id` field should NOT be set at present. See
MESOS-8054.
+ // The `id` field allows frameworks to indicate that they wish to receive
+ // feedback about an operation via the UPDATE_OPERATION_STATUS event in the
+ // v1 scheduler API.
optional OperationID id = 12; // EXPERIMENTAL.
optional Launch launch = 2;
diff --git a/include/mesos/scheduler/scheduler.proto
b/include/mesos/scheduler/scheduler.proto
index 2763415..5443048 100644
--- a/include/mesos/scheduler/scheduler.proto
+++ b/include/mesos/scheduler/scheduler.proto
@@ -130,6 +130,8 @@ message Event {
required TaskStatus status = 1;
}
+ // EXPERIMENTAL.
+ //
// Received when there is an operation status update generated by the master,
// agent, or resource provider. These updates are only sent to the framework
// for operations which had the operation ID set by the framework. It is the
@@ -399,6 +401,8 @@ message Call {
required bytes uuid = 3;
}
+ // EXPERIMENTAL.
+ //
// Acknowledges the receipt of an operation status update. Schedulers
// are responsible for explicitly acknowledging the receipt of updates
// which have the 'UpdateOperationStatus.status().uuid()' field set.
@@ -433,6 +437,8 @@ message Call {
repeated Task tasks = 1;
}
+ // EXPERIMENTAL.
+ //
// Allows the scheduler to query the status of operations. This causes the
// master to send back the latest status for each operation in 'operations',
// if possible. If 'operations' is empty, then the master will send the
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 3656aa7..1d751f6 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -2117,9 +2117,9 @@ message Offer {
optional Type type = 1;
- // NOTE: The `id` field will allow frameworks to indicate that they wish to
- // receive feedback about an operation. Since this feature is not yet
- // implemented, the `id` field should NOT be set at present. See
MESOS-8054.
+ // The `id` field allows frameworks to indicate that they wish to receive
+ // feedback about an operation via the UPDATE_OPERATION_STATUS event in the
+ // v1 scheduler API.
optional OperationID id = 12; // EXPERIMENTAL.
optional Launch launch = 2;
diff --git a/include/mesos/v1/scheduler/scheduler.proto
b/include/mesos/v1/scheduler/scheduler.proto
index 9b0f546..3cfe025 100644
--- a/include/mesos/v1/scheduler/scheduler.proto
+++ b/include/mesos/v1/scheduler/scheduler.proto
@@ -128,6 +128,8 @@ message Event {
required TaskStatus status = 1;
}
+ // EXPERIMENTAL.
+ //
// Received when there is an operation status update generated by the
// master, agent, or resource provider. These updates are only sent to
// the framework for operations which had the operation ID set by the
@@ -384,6 +386,8 @@ message Call {
required bytes uuid = 3;
}
+ // EXPERIMENTAL.
+ //
// Acknowledges the receipt of an operation status update. Schedulers
// are responsible for explicitly acknowledging the receipt of updates
// which have the 'UpdateOperationStatus.status().uuid()' field set.
@@ -418,6 +422,8 @@ message Call {
repeated Task tasks = 1;
}
+ // EXPERIMENTAL.
+ //
// Allows the scheduler to query the status of operations. This causes
// the master to send back the latest status for each operation in
// 'operations', if possible. If 'operations' is empty, then the
@@ -497,6 +503,8 @@ message Call {
}
/**
+ * EXPERIMENTAL.
+ *
* This message is used by the C++ Scheduler HTTP API library as the return
* type of the `call()` method. The message includes the HTTP status code with
* which the master responded, and optionally a `scheduler::Response` message.
