This is an automated email from the ASF dual-hosted git repository.
mzhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 003499f Removed a TODO in sorter utils.
003499f is described below
commit 003499f8b0c81144bc4b06c6f14e1ad1726131b1
Author: Meng Zhu <[email protected]>
AuthorDate: Tue Apr 16 14:40:49 2019 -0600
Removed a TODO in sorter utils.
A prototype implementation of this TODO proves to have very small
performance improvement. This does not justify the extra complexity.
See MESOS-9723.
---
src/master/allocator/sorter/random/utils.hpp | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/master/allocator/sorter/random/utils.hpp
b/src/master/allocator/sorter/random/utils.hpp
index 1329359..6516171 100644
--- a/src/master/allocator/sorter/random/utils.hpp
+++ b/src/master/allocator/sorter/random/utils.hpp
@@ -67,10 +67,6 @@ void weightedShuffle(
[&](size_t i, size_t j){ return keys[i] < keys[j]; });
// Now apply the permutation to `items`.
- //
- // TODO(bmahler): Consider avoiding the copy of entries in `items`
- // via an in-place application of the permutation:
- //
https://blog.merovius.de/2014/08/12/applying-permutation-in-constant.html
std::vector<typename std::iterator_traits<RandomAccessIterator>::value_type>
shuffled(end - begin);
