This is an automated email from the ASF dual-hosted git repository.

grag pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new fa39fe2  Added debug logging when framework is missing during agent 
removal.
fa39fe2 is described below

commit fa39fe2a932de6a6ddccf65e9322738e48c7b39e
Author: Greg Mann <[email protected]>
AuthorDate: Tue Apr 30 10:27:15 2019 -0700

    Added debug logging when framework is missing during agent removal.
    
    This patch adds extra debug logging to `Master::__removeSlave()`
    in order to help triage MESOS-9609 if that issue is observed
    again in the future.
    
    Review: https://reviews.apache.org/r/70559/
---
 src/master/master.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/master/master.cpp b/src/master/master.cpp
index 7dcdc9a..9f0a976 100644
--- a/src/master/master.cpp
+++ b/src/master/master.cpp
@@ -11460,7 +11460,9 @@ void Master::__removeSlave(
   // the framework has opted in to the PARTITION_AWARE capability.
   foreachkey (const FrameworkID& frameworkId, utils::copy(slave->tasks)) {
     Framework* framework = getFramework(frameworkId);
-    CHECK_NOTNULL(framework);
+    CHECK(framework != nullptr)
+      << "Framework " << frameworkId << " not found while removing agent "
+      << *slave << "; agent tasks: " << slave->tasks;
 
     TaskState newTaskState = TASK_UNREACHABLE;
     TaskStatus::Reason newTaskReason = TaskStatus::REASON_SLAVE_REMOVED;

Reply via email to