This is an automated email from the ASF dual-hosted git repository.
jpeach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new d412286 Update `EXPECT` to `ASSERT` in blkio tests.
d412286 is described below
commit d41228696ec88b482d04ede018a316425a35bd09
Author: James Peach <[email protected]>
AuthorDate: Mon Jun 17 18:35:05 2019 -0700
Update `EXPECT` to `ASSERT` in blkio tests.
Since the blkio cgroup tests immediately require the result of
`blkio_statistics()`, we should test for the presence of statistics
with `ASSERT_TRUE` rather than `EXPECT_TRUE`.
Review: https://reviews.apache.org/r/70862/
---
src/tests/containerizer/cgroups_isolator_tests.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tests/containerizer/cgroups_isolator_tests.cpp
b/src/tests/containerizer/cgroups_isolator_tests.cpp
index eef8eb2..f72e6cd 100644
--- a/src/tests/containerizer/cgroups_isolator_tests.cpp
+++ b/src/tests/containerizer/cgroups_isolator_tests.cpp
@@ -1887,7 +1887,7 @@ TEST_F(CgroupsIsolatorTest, ROOT_CGROUPS_BlkioUsage)
// cfq statistics may be 0. And there must be at least two entries in
// the throttling statistics, one is the total statistics, the others
// are device specific statistics.
- EXPECT_TRUE(usage->has_blkio_statistics());
+ ASSERT_TRUE(usage->has_blkio_statistics());
EXPECT_LE(2, usage->blkio_statistics().throttling_size());
// We only check the total throttling statistics.