This is an automated email from the ASF dual-hosted git repository.

mzhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit b172deabec5890aa1c4650be5a41c3bfaf811e1a
Author: Meng Zhu <[email protected]>
AuthorDate: Mon Jun 24 15:43:00 2019 -0700

    Updated the UI to show quota limits differently from guarantees.
    
    Previously, guarantees also acts as limits. But now limits are
    decoupled from guarantees. This patch updates the UI to display
    them separated based on the `/roles` response.
    
    Review: https://reviews.apache.org/r/70939
---
 src/webui/app/roles/roles.html | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/webui/app/roles/roles.html b/src/webui/app/roles/roles.html
index 8dc4d8e..02cb7ba 100644
--- a/src/webui/app/roles/roles.html
+++ b/src/webui/app/roles/roles.html
@@ -64,20 +64,17 @@
         {{((role.quota.guarantee.disk * (1024 * 1024) || NaN) | dataSize) || 
"-"}}
       </td>
 
-      <!-- TODO(ArmandGrillet): Replace by
-        (role.quota.limit.<> | decimalFloat) || (role.quota.guarantee.<> | 
decimalFloat) || "-"
-        once the limit field is introduced. -->
       <td class="begin-group-column">
-        {{(role.quota.guarantee.cpus | decimalFloat) || "-"}}
+        {{(role.quota.limit.cpus | decimalFloat) || "-"}}
       </td>
       <td>
-        {{(role.quota.guarantee.gpus | decimalFloat) || "-"}}
+        {{(role.quota.limit.gpus | decimalFloat) || "-"}}
       </td>
       <td>
-        {{((role.quota.guarantee.mem * (1024 * 1024) || NaN) | dataSize) || 
"-"}}
+        {{((role.quota.limit.mem * (1024 * 1024) || NaN) | dataSize) || "-"}}
       </td>
       <td class="end-group-column">
-        {{((role.quota.guarantee.disk * (1024 * 1024) || NaN) | dataSize) || 
"-"}}
+        {{((role.quota.limit.disk * (1024 * 1024) || NaN) | dataSize) || "-"}}
       </td>
     </tr>
   </tbody>

Reply via email to