This is an automated email from the ASF dual-hosted git repository. josephwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 1bbff126299a5bb633f6f8f1731d500e831dded2 Author: Joseph Wu <[email protected]> AuthorDate: Thu Sep 12 17:46:04 2019 -0700 Added some extra ASSERTs to a role test. These asserts technically aren't required, since subsequent awaiting for offers assumes that the agents are created successfully. However, it seems useful to fail a bit earlier if the agent creation happens to fail. Review: https://reviews.apache.org/r/71481 --- src/tests/role_tests.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/tests/role_tests.cpp b/src/tests/role_tests.cpp index d6cc31b..fb8122b 100644 --- a/src/tests/role_tests.cpp +++ b/src/tests/role_tests.cpp @@ -509,6 +509,7 @@ TEST_F(RoleTest, RolesEndpointContainsConsumedQuota) Owned<MasterDetector> detector = master.get()->createDetector(); Try<Owned<cluster::Slave>> slave1 = StartSlave(detector.get(), agentFlags1); + ASSERT_SOME(slave1); FrameworkInfo frameworkInfo = DEFAULT_FRAMEWORK_INFO; frameworkInfo.set_roles(0, "role"); @@ -556,6 +557,7 @@ TEST_F(RoleTest, RolesEndpointContainsConsumedQuota) agentFlags2.launcher = "posix"; Try<Owned<cluster::Slave>> slave2 = StartSlave(detector.get(), agentFlags2); + ASSERT_SOME(slave2); AWAIT_READY(task2Launched); @@ -580,6 +582,7 @@ TEST_F(RoleTest, RolesEndpointContainsConsumedQuota) agentFlags3.launcher = "posix"; Try<Owned<cluster::Slave>> slave3 = StartSlave(detector.get(), agentFlags3); + ASSERT_SOME(slave3); AWAIT_READY(offer);
