This is an automated email from the ASF dual-hosted git repository.

bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new 87bfb76  Logged failed TLS reverse DNS lookups as warnings for 
'legacy' scheme.
87bfb76 is described below

commit 87bfb76640fbcd83ce1dc48e3ba62d00bb1a4613
Author: Benjamin Mahler <[email protected]>
AuthorDate: Mon Oct 21 19:57:54 2019 -0400

    Logged failed TLS reverse DNS lookups as warnings for 'legacy' scheme.
    
    These were getting logged at VLOG(2), whereas we want all networking
    related errors to be logged as warnings (or errors if appropriate).
    
    Review: https://reviews.apache.org/r/71643
---
 3rdparty/libprocess/src/openssl.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/3rdparty/libprocess/src/openssl.cpp 
b/3rdparty/libprocess/src/openssl.cpp
index 832a1e1..bd05866 100644
--- a/3rdparty/libprocess/src/openssl.cpp
+++ b/3rdparty/libprocess/src/openssl.cpp
@@ -887,8 +887,8 @@ Try<Nothing> verify(
     }
 
     if (lookup.isError()) {
-      VLOG(2) << "Could not determine hostname of peer: "
-              << lookup.error();
+      LOG(WARNING) << "Reverse DNS lookup for '" << ip.get() << "'"
+                   << " failed: " << lookup.error();
     } else {
       VLOG(2) << "Accepting from " << lookup.get();
       peer_hostname = lookup.get();

Reply via email to