This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 776b31c Re-worked TODOs for the RecordIO encoder/decoder.
776b31c is described below
commit 776b31c6658be234497218a9a33e3961075c83e6
Author: Benjamin Mahler <[email protected]>
AuthorDate: Fri Nov 1 15:24:47 2019 -0400
Re-worked TODOs for the RecordIO encoder/decoder.
---
3rdparty/stout/include/stout/recordio.hpp | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/3rdparty/stout/include/stout/recordio.hpp
b/3rdparty/stout/include/stout/recordio.hpp
index bb58eca..9d226c2 100644
--- a/3rdparty/stout/include/stout/recordio.hpp
+++ b/3rdparty/stout/include/stout/recordio.hpp
@@ -44,8 +44,18 @@
* other "Record-IO" implementations use a fixed-size header
* of 4 bytes to directly encode an unsigned 32 bit length.
*
- * TODO(bmahler): Move this to libprocess and support async
- * consumption of data.
+ * TODO(bmahler): Make the encoder and decoder non-templated.
+ * They can just take records as bytes and let a wrapper at
+ * a higher level do what they like with the bytes of each
+ * record.
+ *
+ * TODO(bmahler): Make the encoder and decoder zero-copy,
+ * once they're just dealing with bytes. To make the encoder
+ * zero-copy, we need to make "writes" directly to an output
+ * (e.g. call a callback with bytes to write, or write to a
+ * provided "output stream" abstraction). For the decoder,
+ * we can provide a string view into the input data of the
+ * record.
*/
namespace recordio {
