[mesos] 03/15: Improved error reporting in 'Resources::pushReservation()'.

[bennoe]

This is an automated email from the ASF dual-hosted git repository.

bennoe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit 48d79c25f639d7cd79ca7a78c23ad0e680bcdcbb
Author: Benno Evers <bev...@mesosphere.com>
AuthorDate: Fri Nov 8 13:57:16 2019 +0100

    Improved error reporting in 'Resources::pushReservation()'.
    
    Make sure to print the actual error message after an assertion
    failure in `Resources::pushReservations()`.
    
    Review: https://reviews.apache.org/r/71722/
---
 src/common/resources.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/common/resources.cpp b/src/common/resources.cpp
index bfa9f3e..e3e1100 100644
--- a/src/common/resources.cpp
+++ b/src/common/resources.cpp
@@ -1722,7 +1722,10 @@ Resources Resources::pushReservation(
       resourcesNoMutationWithoutExclusiveOwnership) {
     Resource_ r_ = *resource_;
     r_.resource.add_reservations()->CopyFrom(reservation);
-    CHECK_NONE(Resources::validate(r_.resource));
+    Option<Error> validation = Resources::validate(r_.resource);
+    CHECK_NONE(validation)
+      << "Validation failed: " << *validation;
+
     result.add(std::move(r_));
   }