This is an automated email from the ASF dual-hosted git repository.

qianzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit 968ff95cd4ad51359e3fcb19c2c6f6984a941ae8
Author: Qian Zhang <[email protected]>
AuthorDate: Fri Dec 20 09:42:50 2019 +0800

    Added the `share_cgroups` field into `LinuxInfo`.
    
    Review: https://reviews.apache.org/r/71931
---
 include/mesos/mesos.proto    | 15 +++++++++++++++
 include/mesos/v1/mesos.proto | 15 +++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index e48d6f3..b0f5905 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -3342,6 +3342,21 @@ message LinuxInfo {
   // note that we only support setting this field when the `ipc_mode` field is
   // set to `PRIVATE` otherwise the container launch will be rejected.
   optional uint32 shm_size = 7;
+
+  // If set as 'true', the container will share the cgroups from its parent
+  // container, otherwise it will have its own cgroups created. Please note:
+  // 1. This field should be only used for the task containers in a task group
+  //    (i.e., the 1st level nested containers). It will be ignored for the
+  //    executor containers (i.e., the top-level containers) since the executor
+  //    container will always have its own cgroups created, and it will also be
+  //    ignored for the nested containers under the 1st nested container (e.g.,
+  //    the debug container running as 2nd level nested container) since those
+  //    containers should always share cgroups from its parent container.
+  // 2. The value of this field should be same for all the tasks launched by a
+  //    single executor.
+  // 3. It is not allowed to set resource limits for the task which has this
+  //    field set as true.
+  optional bool share_cgroups = 8 [default = true];
 }
 
 
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 9533261..53a7b9b 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -3331,6 +3331,21 @@ message LinuxInfo {
   // note that we only support setting this field when the `ipc_mode` field is
   // set to `PRIVATE` otherwise the container launch will be rejected.
   optional uint32 shm_size = 7;
+
+  // If set as 'true', the container will share the cgroups from its parent
+  // container, otherwise it will have its own cgroups created. Please note:
+  // 1. This field should be only used for the task containers in a task group
+  //    (i.e., the 1st level nested containers). It will be ignored for the
+  //    executor containers (i.e., the top-level containers) since the executor
+  //    container will always have its own cgroups created, and it will also be
+  //    ignored for the nested containers under the 1st nested container (e.g.,
+  //    the debug container running as 2nd level nested container) since those
+  //    containers should always share cgroups from its parent container.
+  // 2. The value of this field should be same for all the tasks launched by a
+  //    single executor.
+  // 3. It is not allowed to set resource limits for the task which has this
+  //    field set as true.
+  optional bool share_cgroups = 8 [default = true];
 }
 
 

Reply via email to