This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 9ec5e2bd7b5740a9bc694c91e6bbfc0423ca292b
Author: Benjamin Mahler <bmah...@apache.org>
AuthorDate: Thu Mar 5 18:07:02 2020 -0500
Fixed the broken PathTest.PathIteration on windows.
This test uses only linux style paths and fails on windows. This
happened because this code was introduced recently but there was
no testing or CI running on windows to catch it.
Review: https://reviews.apache.org/r/72202
---
3rdparty/stout/tests/path_tests.cpp | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/3rdparty/stout/tests/path_tests.cpp
b/3rdparty/stout/tests/path_tests.cpp
index 1ae80d0..f21b6a8 100644
--- a/3rdparty/stout/tests/path_tests.cpp
+++ b/3rdparty/stout/tests/path_tests.cpp
@@ -445,6 +445,10 @@ TEST(PathTest, FromURI)
}
+// TODO(bmahler): This needs to be tested more comprehensively, see:
+//
https://www.boost.org/doc/libs/1_72_0/libs/filesystem/doc/reference.html#path-decomposition-table
+//
+// NOLINT(whitespace/line_length)
TEST(PathTest, PathIteration)
{
{
@@ -472,7 +476,12 @@ TEST(PathTest, PathIteration)
{
// Checks for behavior of absolute paths.
+#ifdef __WINDOWS__
+ const vector<string> components{"C:", "1", "2", "3", "4", "5", "file.ext"};
+#else
const vector<string> components{"", "1", "2", "3", "4", "5", "file.ext"};
+#endif
+
const Path absolute_path(
strings::join(string(1, os::PATH_SEPARATOR), components));
