This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new da08b0c Fixed a compilation issue on Windows with os::spawn.
da08b0c is described below
commit da08b0cc33d3b6b70a507348783a70ac863cb1dd
Author: Benjamin Mahler <[email protected]>
AuthorDate: Mon Jul 27 13:20:54 2020 -0400
Fixed a compilation issue on Windows with os::spawn.
Per MESOS-10137, the call to os::spawn touched here can be seen
as ambiguous by the compiler, given that windows adds a default
argument to os::spawn. Probably we need to remove the default
argument and explicitly implement os::spawn which calls into the
additional windows os::spawn with the extra environment argument.
---
3rdparty/stout/include/stout/os/windows/shell.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/3rdparty/stout/include/stout/os/windows/shell.hpp
b/3rdparty/stout/include/stout/os/windows/shell.hpp
index 587f061..58902d7 100644
--- a/3rdparty/stout/include/stout/os/windows/shell.hpp
+++ b/3rdparty/stout/include/stout/os/windows/shell.hpp
@@ -165,7 +165,7 @@ Try<std::string> shell(const std::string& fmt, const T&...
t)
inline Option<int> system(const std::string& command)
{
- return os::spawn(Shell::name, {Shell::arg0, Shell::arg1, command});
+ return os::spawn(Shell::name, {Shell::arg0, Shell::arg1, command}, None());
}
} // namespace os {
