This is an automated email from the ASF dual-hosted git repository.

bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new 60283f0a2 [reviewbot] Fix reviewbot build error.
60283f0a2 is described below

commit 60283f0a27edfb54c2d1c39aee20a3fabbc88ae5
Author: Jason Zhou <[email protected]>
AuthorDate: Wed Jul 31 13:04:38 2024 -0700

    [reviewbot] Fix reviewbot build error.
    
    Currently, reviewbot is failing from a 'control reaches end of non-void
    function' error due to a switch case inside a lambda in the device
    manager code. We use an UNREACHABLE macro to stop this error.
    
    Review: https://reviews.apache.org/r/75128/
---
 src/slave/containerizer/device_manager/device_manager.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/slave/containerizer/device_manager/device_manager.cpp 
b/src/slave/containerizer/device_manager/device_manager.cpp
index 9c3e6c00c..5c7c88b98 100644
--- a/src/slave/containerizer/device_manager/device_manager.cpp
+++ b/src/slave/containerizer/device_manager/device_manager.cpp
@@ -24,6 +24,7 @@
 
 #include <stout/foreach.hpp>
 #include <stout/stringify.hpp>
+#include <stout/unreachable.hpp>
 
 #include "slave/containerizer/device_manager/device_manager.hpp"
 #include "slave/paths.hpp"
@@ -59,6 +60,7 @@ vector<Entry> convert_to_entries(
         case DeviceManager::NonWildcardEntry::Selector::Type::CHARACTER:
           return Entry::Selector::Type::CHARACTER;
       }
+      UNREACHABLE();
     }();
     entry.selector.major = non_wildcards_entry.selector.major;
     entry.selector.minor = non_wildcards_entry.selector.minor;

Reply via email to