METRON-1392 Fix a test case to expect an Exception when replication factor more than number of brokers while creating topic (MohanDV via merrimanr) closes apache/metron#892
Project: http://git-wip-us.apache.org/repos/asf/metron/repo Commit: http://git-wip-us.apache.org/repos/asf/metron/commit/a421df22 Tree: http://git-wip-us.apache.org/repos/asf/metron/tree/a421df22 Diff: http://git-wip-us.apache.org/repos/asf/metron/diff/a421df22 Branch: refs/heads/feature/METRON-1344-test-infrastructure Commit: a421df228b66d2100c29c2adee4248f35a70cafb Parents: 24822dd Author: MohanDV <mohan...@gmail.com> Authored: Fri Jan 26 08:21:51 2018 -0600 Committer: merrimanr <merrim...@apache.org> Committed: Fri Jan 26 08:21:51 2018 -0600 ---------------------------------------------------------------------- .../metron/rest/service/impl/KafkaServiceImplTest.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/metron/blob/a421df22/metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/KafkaServiceImplTest.java ---------------------------------------------------------------------- diff --git a/metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/KafkaServiceImplTest.java b/metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/KafkaServiceImplTest.java index 1f300ea..4527e8e 100644 --- a/metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/KafkaServiceImplTest.java +++ b/metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/KafkaServiceImplTest.java @@ -252,15 +252,10 @@ public class KafkaServiceImplTest { @Test public void createTopicShouldFailIfReplicationFactorIsGreaterThanAvailableBrokers() throws Exception { - final Map<String, List<PartitionInfo>> topics = new HashMap<>(); - - when(kafkaConsumer.listTopics()).thenReturn(topics); - + exception.expect(RestException.class); + doThrow(AdminOperationException.class).when(adminUtils).createTopic(eq(zkUtils), eq("t"), eq(1), eq(2), eq(new Properties()), eq(RackAwareMode.Disabled$.MODULE$)); kafkaService.createTopic(VALID_KAFKA_TOPIC); - verify(adminUtils).createTopic(eq(zkUtils), eq("t"), eq(1), eq(2), eq(new Properties()), eq(RackAwareMode.Disabled$.MODULE$)); - verify(kafkaConsumer).listTopics(); - verifyZeroInteractions(zkUtils); } @Test
