svn commit: r579965 - in /mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr: AprConnector.java AprIoProcessor.java

[trustin]

Author: trustin
Date: Thu Sep 27 03:06:38 2007
New Revision: 579965

URL: http://svn.apache.org/viewvc?rev=579965&view=rev
Log:
* Removed unused local variables
* Added some fixme

Modified:
    
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprConnector.java
    
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java

Modified: 
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprConnector.java
URL: 
http://svn.apache.org/viewvc/mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprConnector.java?rev=579965&r1=579964&r2=579965&view=diff
==============================================================================
--- 
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprConnector.java
 (original)
+++ 
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprConnector.java
 Thu Sep 27 03:06:38 2007
@@ -55,7 +55,8 @@
 
     private final int id = nextId++;
 
-    // private final String threadName = "APRConnector-" + id;
+    private final String threadName = "APRConnector-" + id;
+
     private final int processorCount;
 
     private final Executor executor;
@@ -106,15 +107,15 @@
         ioProcessors = new AprIoProcessor[processorCount];
 
         for (int i = 0; i < processorCount; i++) {
-            ioProcessors[i] = new AprIoProcessor("APRConnectorIoProcessor-"
-                    + id + "." + i, executor);
+            ioProcessors[i] = new AprIoProcessor(
+                    threadName + "." + i, executor);
         }
     }
 
     @Override
     protected ConnectFuture doConnect(SocketAddress remoteAddress,
             SocketAddress localAddress) {
-        boolean success = false;
+        // FIXME: this operation should be non-blocking and asynchronous like 
NioSocketConnector.
         try {
             InetSocketAddress sockAddr = (InetSocketAddress) remoteAddress;
             //pool = Pool.create(pool);
@@ -163,8 +164,6 @@
             // Forward the remaining process to the APRIoProcessor.
             // it's will validate the COnnectFuture when the session is in the 
poll set
             session.getIoProcessor().add(session);
-
-            success = true;
             return future;
         } catch (Exception e) {
             return DefaultConnectFuture.newFailedFuture(e);

Modified: 
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java
URL: 
http://svn.apache.org/viewvc/mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java?rev=579965&r1=579964&r2=579965&view=diff
==============================================================================
--- 
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java
 (original)
+++ 
mina/trunk/transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java
 Thu Sep 27 03:06:38 2007
@@ -123,8 +123,6 @@
 
     @Override
     protected Iterator<AbstractIoSession> allSessions() throws Exception {
-        
-        // TODO Auto-generated method stub
         return new IoSessionIterator(managedSessions.values());
     }