Author: trustin
Date: Sat Sep 29 12:47:36 2007
New Revision: 580631

URL: http://svn.apache.org/viewvc?rev=580631&view=rev
Log:
Removed code duplication in ExecutorFilter and its friends

Modified:
    
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/AbstractExecutorFilter.java
    
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java
    
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/UnorderedExecutorFilter.java

Modified: 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/AbstractExecutorFilter.java
URL: 
http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/executor/AbstractExecutorFilter.java?rev=580631&r1=580630&r2=580631&view=diff
==============================================================================
--- 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/AbstractExecutorFilter.java
 (original)
+++ 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/AbstractExecutorFilter.java
 Sat Sep 29 12:47:36 2007
@@ -185,39 +185,4 @@
             nextFilter.filterClose(session);
         }
     }
-
-    protected final void processEvent(IoFilterEvent event) {
-        NextFilter nextFilter = event.getNextFilter();
-        IoSession session = event.getSession();
-        Object data = event.getParameter();
-
-        switch (event.getType()) {
-        case MESSAGE_RECEIVED:
-            nextFilter.messageReceived(session, data);
-            break;
-        case MESSAGE_SENT:
-            nextFilter.messageSent(session, (WriteRequest) data);
-            break;
-        case WRITE:
-            nextFilter.filterWrite(session, (WriteRequest) data);
-            break;
-        case CLOSE:
-            nextFilter.filterClose(session);
-            break;
-        case EXCEPTION_CAUGHT:
-            nextFilter.exceptionCaught(session, (Throwable) data);
-            break;
-        case SESSION_IDLE:
-            nextFilter.sessionIdle(session, (IdleStatus) data);
-            break;
-        case SESSION_OPENED:
-            nextFilter.sessionOpened(session);
-            break;
-        case SESSION_CLOSED:
-            nextFilter.sessionClosed(session);
-            break;
-        default:
-            throw new InternalError("Unknown event type: " + event.getType());
-        }
-    }
 }

Modified: 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java
URL: 
http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java?rev=580631&r1=580630&r2=580631&view=diff
==============================================================================
--- 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java
 (original)
+++ 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/ExecutorFilter.java
 Sat Sep 29 12:47:36 2007
@@ -153,7 +153,7 @@
                     }
                 }
 
-                processEvent(event);
+                event.fire();
             }
 
             if (logger.isDebugEnabled()) {

Modified: 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/UnorderedExecutorFilter.java
URL: 
http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/executor/UnorderedExecutorFilter.java?rev=580631&r1=580630&r2=580631&view=diff
==============================================================================
--- 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/UnorderedExecutorFilter.java
 (original)
+++ 
mina/trunk/core/src/main/java/org/apache/mina/filter/executor/UnorderedExecutorFilter.java
 Sat Sep 29 12:47:36 2007
@@ -80,7 +80,7 @@
         }
 
         public void run() {
-            processEvent(event);
+            event.fire();
         }
     }
 }


Reply via email to