Author: apaliwal
Date: Thu Apr 9 08:33:36 2009
New Revision: 763558
URL: http://svn.apache.org/viewvc?rev=763558&view=rev
Log:
Removed empty catch(), unused import PMD warning
Submitted By: Ashish Paliwal (apaliwal.at.apache.org)
Modified:
mina/trunk/core/src/test/java/org/apache/mina/core/FutureTest.java
mina/trunk/core/src/test/java/org/apache/mina/filter/codec/textline/TextLineDecoderTest.java
mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/SubnetIPv6Test.java
mina/trunk/core/src/test/java/org/apache/mina/filter/reqres/RequestResponseFilterTest.java
mina/trunk/core/src/test/java/org/apache/mina/filter/stream/AbstractStreamWriteFilterTest.java
mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
Modified: mina/trunk/core/src/test/java/org/apache/mina/core/FutureTest.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/core/FutureTest.java?rev=763558&r1=763557&r2=763558&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/core/FutureTest.java
(original)
+++ mina/trunk/core/src/test/java/org/apache/mina/core/FutureTest.java Thu Apr
9 08:33:36 2009
@@ -99,6 +99,8 @@
future.getSession();
fail("IOException should be thrown.");
} catch (Exception e) {
+ // Signifies a successful test execution
+ assertTrue(true);
}
}
Modified:
mina/trunk/core/src/test/java/org/apache/mina/filter/codec/textline/TextLineDecoderTest.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/filter/codec/textline/TextLineDecoderTest.java?rev=763558&r1=763557&r2=763558&view=diff
==============================================================================
---
mina/trunk/core/src/test/java/org/apache/mina/filter/codec/textline/TextLineDecoderTest.java
(original)
+++
mina/trunk/core/src/test/java/org/apache/mina/filter/codec/textline/TextLineDecoderTest.java
Thu Apr 9 08:33:36 2009
@@ -282,7 +282,8 @@
decoder.decode(session, in, out);
Assert.fail();
} catch (RecoverableProtocolDecoderException e) {
- // Success!
+ // signifies a successful test execution
+ Assert.assertTrue(true);
}
decoder.decode(session, in, out);
@@ -306,7 +307,8 @@
decoder.decode(session, in, out);
Assert.fail();
} catch (RecoverableProtocolDecoderException e) {
- // Success!
+ // signifies a successful test execution
+ Assert.assertTrue(true);
}
decoder.decode(session, in, out);
Modified:
mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/SubnetIPv6Test.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/SubnetIPv6Test.java?rev=763558&r1=763557&r2=763558&view=diff
==============================================================================
---
mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/SubnetIPv6Test.java
(original)
+++
mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/SubnetIPv6Test.java
Thu Apr 9 08:33:36 2009
@@ -25,6 +25,7 @@
import java.net.UnknownHostException;
import junit.framework.TestCase;
+import junit.framework.Assert;
/**
* TODO Add documentation
@@ -34,15 +35,19 @@
*/
public class SubnetIPv6Test extends TestCase {
+ // Test Data
+ private static final String TEST_V6ADDRESS = "1080:0:0:0:8:800:200C:417A";
+
public void testIPv6() throws UnknownHostException {
- InetAddress a =
InetAddress.getByName("1080:0:0:0:8:800:200C:417A");
+ InetAddress a = InetAddress.getByName(TEST_V6ADDRESS);
assertTrue(a instanceof Inet6Address);
try {
new Subnet(a, 24);
fail("IPv6 not supported");
} catch(IllegalArgumentException e) {
- // OK
+ // signifies a successful test execution
+ Assert.assertTrue(true);
}
}
}
Modified:
mina/trunk/core/src/test/java/org/apache/mina/filter/reqres/RequestResponseFilterTest.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/filter/reqres/RequestResponseFilterTest.java?rev=763558&r1=763557&r2=763558&view=diff
==============================================================================
---
mina/trunk/core/src/test/java/org/apache/mina/filter/reqres/RequestResponseFilterTest.java
(original)
+++
mina/trunk/core/src/test/java/org/apache/mina/filter/reqres/RequestResponseFilterTest.java
Thu Apr 9 08:33:36 2009
@@ -123,7 +123,8 @@
req.awaitResponse();
Assert.fail();
} catch (NoSuchElementException e) {
- // OK
+ // Signifies a successful test execution
+ Assert.assertTrue(true);
}
}
@@ -194,7 +195,8 @@
req.awaitResponse();
Assert.fail();
} catch (RequestTimeoutException e) {
- // OK
+ // Signifies a successful test execution
+ Assert.assertTrue(true);
}
}
Modified:
mina/trunk/core/src/test/java/org/apache/mina/filter/stream/AbstractStreamWriteFilterTest.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/filter/stream/AbstractStreamWriteFilterTest.java?rev=763558&r1=763557&r2=763558&view=diff
==============================================================================
---
mina/trunk/core/src/test/java/org/apache/mina/filter/stream/AbstractStreamWriteFilterTest.java
(original)
+++
mina/trunk/core/src/test/java/org/apache/mina/filter/stream/AbstractStreamWriteFilterTest.java
Thu Apr 9 08:33:36 2009
@@ -29,6 +29,7 @@
import java.util.concurrent.TimeUnit;
import junit.framework.TestCase;
+import junit.framework.Assert;
import org.apache.mina.core.buffer.IoBuffer;
import org.apache.mina.core.filterchain.IoFilter.NextFilter;
@@ -302,6 +303,8 @@
fail("0 writeBuferSize specified. IllegalArgumentException
expected.");
} catch (IllegalArgumentException iae) {
// Pass, exception was thrown
+ // Signifies a successful test execution
+ Assert.assertTrue(true);
}
try {
@@ -309,6 +312,8 @@
fail("Negative writeBuferSize specified. IllegalArgumentException
expected.");
} catch (IllegalArgumentException iae) {
// Pass, exception was thrown
+ // Signifies a successful test execution
+ Assert.assertTrue(true);
}
filter.setWriteBufferSize(1);
Modified:
mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java?rev=763558&r1=763557&r2=763558&view=diff
==============================================================================
---
mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
(original)
+++
mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java
Thu Apr 9 08:33:36 2009
@@ -116,7 +116,8 @@
future.getSession().close(true);
fail();
} catch (RuntimeIoException e) {
- // OK.
+ // Signifies a successful test execution
+ assertTrue(true);
}
Assert.assertEquals("1", buf.toString());
} finally {
