Author: edeoliveira
Date: Tue Jun 30 22:15:06 2009
New Revision: 789983
URL: http://svn.apache.org/viewvc?rev=789983&view=rev
Log:
Negative logic is bad for code clarity
Modified:
mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
Modified:
mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
URL:
http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java?rev=789983&r1=789982&r2=789983&view=diff
==============================================================================
---
mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
(original)
+++
mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
Tue Jun 30 22:15:06 2009
@@ -266,13 +266,13 @@
return;
}
- if (!(writeRequest instanceof MessageWriteRequest)) {
- nextFilter.messageSent(session, writeRequest);
- return;
+ if (writeRequest instanceof MessageWriteRequest) {
+ MessageWriteRequest wrappedRequest = (MessageWriteRequest)
writeRequest;
+ nextFilter.messageSent(session,
wrappedRequest.getParentRequest());
}
-
- MessageWriteRequest wrappedRequest = (MessageWriteRequest)
writeRequest;
- nextFilter.messageSent(session, wrappedRequest.getParentRequest());
+ else {
+ nextFilter.messageSent(session, writeRequest);
+ }
}
@Override
