[4/6] git commit: Used a StringBuilder instead of concatenating Strings in a loop

[elecharny]

Used a StringBuilder instead of concatenating Strings in a loop

Project: http://git-wip-us.apache.org/repos/asf/mina/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina/commit/dfb570bc
Tree: http://git-wip-us.apache.org/repos/asf/mina/tree/dfb570bc
Diff: http://git-wip-us.apache.org/repos/asf/mina/diff/dfb570bc

Branch: refs/heads/trunk
Commit: dfb570bc272edac673ad61ed1e7ccaf996b1750c
Parents: 19d71a5
Author: Emmanuel Lécharny <elecha...@apache.org>
Authored: Sun May 12 00:22:48 2013 +0200
Committer: Emmanuel Lécharny <elecha...@apache.org>
Committed: Sun May 12 00:22:48 2013 +0200

----------------------------------------------------------------------
 .../apache/mina/http/api/DefaultHttpResponse.java  |   72 ++++++++++-----
 1 files changed, 49 insertions(+), 23 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mina/blob/dfb570bc/http/src/main/java/org/apache/mina/http/api/DefaultHttpResponse.java
----------------------------------------------------------------------
diff --git 
a/http/src/main/java/org/apache/mina/http/api/DefaultHttpResponse.java 
b/http/src/main/java/org/apache/mina/http/api/DefaultHttpResponse.java
index 403788b..7d957a4 100644
--- a/http/src/main/java/org/apache/mina/http/api/DefaultHttpResponse.java
+++ b/http/src/main/java/org/apache/mina/http/api/DefaultHttpResponse.java
@@ -19,14 +19,17 @@
  */
 package org.apache.mina.http.api;
 
+
 import java.nio.ByteBuffer;
 import java.util.Map;
 
+
 /**
  * 
  * @author <a href="http://mina.apache.org";>Apache MINA Project</a>
  */
-public class DefaultHttpResponse implements HttpResponse {
+public class DefaultHttpResponse implements HttpResponse
+{
 
     private final HttpVersion version;
 
@@ -34,91 +37,114 @@ public class DefaultHttpResponse implements HttpResponse {
 
     private final Map<String, String> headers;
 
-    public DefaultHttpResponse(HttpVersion version, HttpStatus status, 
Map<String, String> headers) {
+
+    public DefaultHttpResponse( HttpVersion version, HttpStatus status, 
Map<String, String> headers )
+    {
         this.version = version;
         this.status = status;
         this.headers = headers;
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public HttpVersion getProtocolVersion() {
+    public HttpVersion getProtocolVersion()
+    {
         return version;
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public String getContentType() {
-        return headers.get("content-type");
+    public String getContentType()
+    {
+        return headers.get( "content-type" );
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public boolean isKeepAlive() {
+    public boolean isKeepAlive()
+    {
         // TODO check header and version for keep alive
         return false;
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public String getHeader(String name) {
-        return headers.get(name);
+    public String getHeader( String name )
+    {
+        return headers.get( name );
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public boolean containsHeader(String name) {
-        return headers.containsKey(name);
+    public boolean containsHeader( String name )
+    {
+        return headers.containsKey( name );
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public Map<String, String> getHeaders() {
+    public Map<String, String> getHeaders()
+    {
         return headers;
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public HttpStatus getStatus() {
+    public HttpStatus getStatus()
+    {
         return status;
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public ByteBuffer encode(HttpPduEncodingVisitor visitor) {
-        return visitor.visit(this);
+    public ByteBuffer encode( HttpPduEncodingVisitor visitor )
+    {
+        return visitor.visit( this );
     }
 
+
     /**
      * {@inheritDoc}
      */
     @Override
-    public String toString() {
-        String result = "HTTP RESPONSE STATUS: " + status + "\n";
-        result += "VERSION: " + version + "\n";
-
-        result += "--- HEADER --- \n";
-        for (String key : headers.keySet()) {
-            String value = headers.get(key);
-            result += key + ":" + value + "\n";
+    public String toString()
+    {
+        StringBuilder sb = new StringBuilder();
+        sb.append( "HTTP RESPONSE STATUS: " ).append( status ).append( '\n' );
+        sb.append( "VERSION: " ).append( version ).append( '\n' );
+
+        sb.append( "--- HEADER --- \n" );
+
+        for ( String key : headers.keySet() )
+        {
+            String value = headers.get( key );
+            sb.append( key ).append( ':' ).append( value ).append( '\n' );
         }
 
-        return result;
+        return sb.toString();
     }
 }