Repository: mina-sshd Updated Branches: refs/heads/master b737b07d2 -> a5c23a552
[SSHD-737] Standardize code for SignatureDSATest Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/6fbed0c8 Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/6fbed0c8 Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/6fbed0c8 Branch: refs/heads/master Commit: 6fbed0c8d758851d295ec498bf70252dde0aaf76 Parents: b737b07 Author: Lyor Goldstein <[email protected]> Authored: Sat Sep 23 17:49:19 2017 +0300 Committer: Lyor Goldstein <[email protected]> Committed: Sat Sep 23 17:49:19 2017 +0300 ---------------------------------------------------------------------- .../sshd/common/signature/SignatureDSATest.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/6fbed0c8/sshd-core/src/test/java/org/apache/sshd/common/signature/SignatureDSATest.java ---------------------------------------------------------------------- diff --git a/sshd-core/src/test/java/org/apache/sshd/common/signature/SignatureDSATest.java b/sshd-core/src/test/java/org/apache/sshd/common/signature/SignatureDSATest.java index a5cfd37..2224c1d 100644 --- a/sshd-core/src/test/java/org/apache/sshd/common/signature/SignatureDSATest.java +++ b/sshd-core/src/test/java/org/apache/sshd/common/signature/SignatureDSATest.java @@ -25,22 +25,24 @@ import java.security.spec.DSAPublicKeySpec; import org.apache.sshd.common.config.keys.KeyUtils; import org.apache.sshd.common.util.security.SecurityUtils; -import org.junit.Assert; +import org.apache.sshd.util.test.BaseTestSupport; +import org.junit.FixMethodOrder; import org.junit.Test; +import org.junit.runners.MethodSorters; /** - * @author Kermit the frog + * @author <a href="mailto:[email protected]";>Apache MINA SSHD Project</a> */ -public class SignatureDSATest { +@FixMethodOrder(MethodSorters.NAME_ASCENDING) +public class SignatureDSATest extends BaseTestSupport { public SignatureDSATest() { + super(); } @Test public void testTooShortSignature() throws Exception { - KeyFactory kf = SecurityUtils.getKeyFactory(KeyUtils.DSS_ALGORITHM); - - final SignatureDSA signatureDSA = new SignatureDSA("DSA") { + SignatureDSA signatureDSA = new SignatureDSA(KeyUtils.DSS_ALGORITHM) { @Override protected java.security.Signature doInitSignature(String algo, boolean forSigning) throws GeneralSecurityException { return java.security.Signature.getInstance(algo); @@ -99,6 +101,6 @@ public class SignatureDSATest { -1, -78, 112, -88, 14, -39, -78, -98, -80 }; boolean verified = signatureDSA.verify(sig_of_h); - Assert.assertTrue(verified); + assertTrue(verified); } } \ No newline at end of file
