This is an automated email from the ASF dual-hosted git repository.

lgoldstein pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mina-sshd.git

commit 2721d4df3fe2c5a6e582e48c2d7387fe2f970958
Author: The-Yoda <[email protected]>
AuthorDate: Tue Feb 12 12:08:07 2019 +0200

    [SSHD-894] Fix Race condition when doing async auth.
---
 .../java/org/apache/sshd/server/session/ServerUserAuthService.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/sshd-core/src/main/java/org/apache/sshd/server/session/ServerUserAuthService.java
 
b/sshd-core/src/main/java/org/apache/sshd/server/session/ServerUserAuthService.java
index c596cf7..653d8b1 100644
--- 
a/sshd-core/src/main/java/org/apache/sshd/server/session/ServerUserAuthService.java
+++ 
b/sshd-core/src/main/java/org/apache/sshd/server/session/ServerUserAuthService.java
@@ -359,11 +359,12 @@ public class ServerUserAuthService extends 
AbstractCloseable implements Service,
                 sendWelcomeBanner(session);
             }
 
-            Buffer response = 
session.createBuffer(SshConstants.SSH_MSG_USERAUTH_SUCCESS, Byte.SIZE);
-            session.writePacket(response);
             session.setUsername(username);
             session.setAuthenticated();
             session.startService(authService, buffer);
+
+            Buffer response = 
session.createBuffer(SshConstants.SSH_MSG_USERAUTH_SUCCESS, Byte.SIZE);
+            session.writePacket(response);
             session.resetIdleTimeout();
             log.info("Session {}@{} authenticated", username, 
session.getIoSession().getRemoteAddress());
         } else {

Reply via email to