(mina-sshd) branch master updated: GH-642: Revert "JceRandom: use SecureRandom.getInstanceStrong()"

[twolf]

This is an automated email from the ASF dual-hosted git repository.

twolf pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mina-sshd.git


The following commit(s) were added to refs/heads/master by this push:
     new 0d65679ed GH-642: Revert "JceRandom: use 
SecureRandom.getInstanceStrong()"
0d65679ed is described below

commit 0d65679ed8b6ac3df844fd8581d9b7f18f236d66
Author: Thomas Wolf <tw...@apache.org>
AuthorDate: Thu Dec 19 17:57:02 2024 +0100

    GH-642: Revert "JceRandom: use SecureRandom.getInstanceStrong()"
    
    This reverts commit 3cc9d481f727793fb8c878181e0adcc07669d450.
    
    Do _not_ use a strong RNG; it may run into entropy starvation. Just
    plain new SecureRandom() is good enough.
---
 .../main/java/org/apache/sshd/common/random/JceRandom.java | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git 
a/sshd-common/src/main/java/org/apache/sshd/common/random/JceRandom.java 
b/sshd-common/src/main/java/org/apache/sshd/common/random/JceRandom.java
index f360b854e..a7769f35d 100644
--- a/sshd-common/src/main/java/org/apache/sshd/common/random/JceRandom.java
+++ b/sshd-common/src/main/java/org/apache/sshd/common/random/JceRandom.java
@@ -18,23 +18,16 @@
  */
 package org.apache.sshd.common.random;
 
-import java.security.NoSuchAlgorithmException;
 import java.security.SecureRandom;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 /**
  * A <code>Random</code> implementation using the built-in {@link 
SecureRandom} PRNG.
  *
  * @author <a href="mailto:d...@mina.apache.org";>Apache MINA SSHD Project</a>
  */
 public class JceRandom extends AbstractRandom {
-
     public static final String NAME = "JCE";
 
-    private static final Logger LOG = LoggerFactory.getLogger(JceRandom.class);
-
     private byte[] tmp = new byte[16];
     private final SecureRandom random = getRandom();
 
@@ -43,12 +36,7 @@ public class JceRandom extends AbstractRandom {
     }
 
     private static SecureRandom getRandom() {
-        try {
-            return SecureRandom.getInstanceStrong();
-        } catch (NoSuchAlgorithmException e) {
-            LOG.warn("No strong SecureRandom algorithm available; falling back 
to non-strong SecureRandom PRNG.");
-            return new SecureRandom();
-        }
+        return new SecureRandom();
     }
 
     private static final class Cache {